Skip to content

Commit

Permalink
Fix missing mode property on file wrapper
Browse files Browse the repository at this point in the history
Without this property, uploads using `requests` fails to set the
Content-Length header, and falls back to chunked encoding,
which many hosts (e.g. S3) don't support.
  • Loading branch information
oefe committed Aug 27, 2022
1 parent e2716d3 commit f8b536c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Fix NO_COLOR support on legacy Windows https://github.com/Textualize/rich/pull/2458
- Fix missing `mode` property on file wrapper breaking uploads via `requests`

## [12.5.2] - 2022-07-18

Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The following people have contributed to the development of Rich:
- [Paul McGuire](https://github.com/ptmcg)
- [Antony Milne](https://github.com/AntonyMilneQB)
- [Michael Milton](https://github.com/multimeric)
- [Martina Oefelein](https://github.com/oefe)
- [Nathan Page](https://github.com/nathanrpage97)
- [Avi Perl](https://github.com/avi-perl)
- [Laurent Peuch](https://github.com/psycojoker)
Expand Down
4 changes: 4 additions & 0 deletions rich/progress.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@ def fileno(self) -> int:
def isatty(self) -> bool:
return self.handle.isatty()

@property
def mode(self) -> str:
return self.handle.mode

@property
def name(self) -> str:
return self.handle.name
Expand Down
1 change: 1 addition & 0 deletions tests/test_progress.py
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,7 @@ def test_wrap_file() -> None:
with open(filename, "rb") as file:
with rich.progress.wrap_file(file, total=total) as f:
assert f.read() == b"Hello, World!"
assert f.mode == "rb"
assert f.name == filename
assert f.closed
assert not f.handle.closed
Expand Down

0 comments on commit f8b536c

Please sign in to comment.