Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of whitespace-only filenames #439

Merged
merged 4 commits into from Dec 31, 2023

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Dec 31, 2023

As reported in TestableIO/System.IO.Abstractions#1070, whitespace-only files are treated differently depending on the underlying operating system:

  • Windows only supports unicode-whitespace, but throws on filenames with only blanks
  • Linux supports both files with only blanks or with unicode-whitespace

@vbreuss vbreuss added the bug Something isn't working label Dec 31, 2023
@vbreuss vbreuss self-assigned this Dec 31, 2023
@vbreuss vbreuss marked this pull request as ready for review December 31, 2023 13:54
@vbreuss vbreuss changed the title fix: whitespace-only filenames fix: handling of whitespace-only filenames Dec 31, 2023
@vbreuss vbreuss merged commit e8e1ef7 into main Dec 31, 2023
9 checks passed
@vbreuss vbreuss deleted the topic/whitespace-only-filenames branch December 31, 2023 13:58
Copy link

github-actions bot commented Jan 7, 2024

This is addressed in release v2.6.1.

mergify bot pushed a commit that referenced this pull request Jan 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[Testably.Abstractions](https://togithub.com/Testably/Testably.Abstractions)
| `2.6.0` -> `2.6.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Testably.Abstractions/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Testably.Abstractions/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Testably.Abstractions/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Testably.Abstractions/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[Testably.Abstractions.Testing](https://togithub.com/Testably/Testably.Abstractions)
| `2.6.0` -> `2.6.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Testably.Abstractions.Testing/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Testably.Abstractions.Testing/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Testably.Abstractions.Testing/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Testably.Abstractions.Testing/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions
(Testably.Abstractions)</summary>

###
[`v2.6.1`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v2.6.1)

##### What's Changed

- chore(deps): update testably.abstractions packages to v2.6.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[#425
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[#426
- chore(deps): update dependency microsoft.codeanalysis.csharp to v4.8.0
by [@&#8203;renovate](https://togithub.com/renovate) in
[#427
- chore(deps): update dependency autofixture.xunit2 to v4.18.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[#428
- chore(deps): update actions/setup-java action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[#429
- chore(deps): update actions/setup-dotnet action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[#430
- chore(deps): update dependency testableio.system.io.abstractions to
v20 by [@&#8203;renovate](https://togithub.com/renovate) in
[#432
- chore(deps): update dependency testableio.system.io.abstractions to
v20.0.4 by [@&#8203;renovate](https://togithub.com/renovate) in
[#433
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[#434
- chore(deps): update actions/download-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[#435
- chore(deps): update actions/upload-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[#436
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[#437
- chore(deps): update apexskier/github-release-commenter action to
v1.3.6 by [@&#8203;renovate](https://togithub.com/renovate) in
[#438
- fix: handling of whitespace-only filenames by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[#439
- fix: use correct empty name for `IFileInfo` with trailing directory
separator char by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[#440
- chore(deps): update dependency xunit to v2.6.5 by
[@&#8203;renovate](https://togithub.com/renovate) in
[#441
- refactor: fix sonar issues due to updated analyzers by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[#443
- fix: remove `test-report.yml` build pipeline by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[#444
- fix: sonar issue `xUnit1040` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[#445
- fix: failing build by [@&#8203;vbreuss](https://togithub.com/vbreuss)
in
[#446

**Full Changelog**:
v2.6.0...v2.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mergify bot pushed a commit to Testably/Testably.Abstractions.FluentAssertions that referenced this pull request Jan 7, 2024
…6.1 (#80)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[Testably.Abstractions.Interface](https://togithub.com/Testably/Testably.Abstractions)
| `2.6.0` -> `2.6.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Testably.Abstractions.Interface/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Testably.Abstractions.Interface/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Testably.Abstractions.Interface/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Testably.Abstractions.Interface/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions
(Testably.Abstractions.Interface)</summary>

###
[`v2.6.1`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v2.6.1)

##### What's Changed

- chore(deps): update testably.abstractions packages to v2.6.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#425
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#426
- chore(deps): update dependency microsoft.codeanalysis.csharp to v4.8.0
by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#427
- chore(deps): update dependency autofixture.xunit2 to v4.18.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#428
- chore(deps): update actions/setup-java action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#429
- chore(deps): update actions/setup-dotnet action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#430
- chore(deps): update dependency testableio.system.io.abstractions to
v20 by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#432
- chore(deps): update dependency testableio.system.io.abstractions to
v20.0.4 by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#433
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#434
- chore(deps): update actions/download-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#435
- chore(deps): update actions/upload-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#436
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#437
- chore(deps): update apexskier/github-release-commenter action to
v1.3.6 by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#438
- fix: handling of whitespace-only filenames by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#439
- fix: use correct empty name for `IFileInfo` with trailing directory
separator char by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#440
- chore(deps): update dependency xunit to v2.6.5 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#441
- refactor: fix sonar issues due to updated analyzers by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#443
- fix: remove `test-report.yml` build pipeline by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#444
- fix: sonar issue `xUnit1040` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#445
- fix: failing build by [@&#8203;vbreuss](https://togithub.com/vbreuss)
in
[Testably/Testably.Abstractions#446

**Full Changelog**:
Testably/Testably.Abstractions@v2.6.0...v2.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mergify bot pushed a commit to Testably/Testably.Abstractions.FluentAssertions that referenced this pull request Jan 7, 2024
#81)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[Testably.Abstractions.Testing](https://togithub.com/Testably/Testably.Abstractions)
| `2.6.0` -> `2.6.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Testably.Abstractions.Testing/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Testably.Abstractions.Testing/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Testably.Abstractions.Testing/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Testably.Abstractions.Testing/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions
(Testably.Abstractions.Testing)</summary>

###
[`v2.6.1`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v2.6.1)

##### What's Changed

- chore(deps): update testably.abstractions packages to v2.6.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#425
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#426
- chore(deps): update dependency microsoft.codeanalysis.csharp to v4.8.0
by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#427
- chore(deps): update dependency autofixture.xunit2 to v4.18.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#428
- chore(deps): update actions/setup-java action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#429
- chore(deps): update actions/setup-dotnet action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#430
- chore(deps): update dependency testableio.system.io.abstractions to
v20 by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#432
- chore(deps): update dependency testableio.system.io.abstractions to
v20.0.4 by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#433
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#434
- chore(deps): update actions/download-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#435
- chore(deps): update actions/upload-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#436
- chore(deps): update xunit-dotnet monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#437
- chore(deps): update apexskier/github-release-commenter action to
v1.3.6 by [@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#438
- fix: handling of whitespace-only filenames by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#439
- fix: use correct empty name for `IFileInfo` with trailing directory
separator char by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#440
- chore(deps): update dependency xunit to v2.6.5 by
[@&#8203;renovate](https://togithub.com/renovate) in
[Testably/Testably.Abstractions#441
- refactor: fix sonar issues due to updated analyzers by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#443
- fix: remove `test-report.yml` build pipeline by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#444
- fix: sonar issue `xUnit1040` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[Testably/Testably.Abstractions#445
- fix: failing build by [@&#8203;vbreuss](https://togithub.com/vbreuss)
in
[Testably/Testably.Abstractions#446

**Full Changelog**:
Testably/Testably.Abstractions@v2.6.0...v2.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working state: released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant