Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make mocked data lazy-loaded #900

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: Make mocked data lazy-loaded #900

wants to merge 5 commits into from

Commits on Oct 25, 2022

  1. chg: Make mocked data lazy-loaded

    @hangy
    hangy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ae24de9 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. test: Re-add MockFileInfo_Exists_* test 

    Test is renamed from MockFileInfo_Exists_ShouldReturnCachedData to
MockFileInfo_Exists_LazyLoadsData, and now checks that the lazy-loading
in MockFileInfo works correctly.

Co-authored-by: Peter Baumann <peter.baumann@gmail.com>
    @hangy @siprbaum
    hangy and siprbaum committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    6111a9a View commit details
    Browse the repository at this point in the history

  2. test: Rename test to reflect that it is actually about lazy-loading

    @hangy
    hangy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4069e71 View commit details
    Browse the repository at this point in the history

  3. fix(test): Call Refresh() in the Arrange phase 

    `Refresh()` needs to be called in the Arrange phase, so that the data is not simply
lazy-loaded in the assertion case. Explicitly loading MockFileData by calling `Refres()`
enforces lazy-loading to be done.

Co-authored-by: Peter Baumann <peter.baumann@gmail.com>
    @hangy @siprbaum
    hangy and siprbaum committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2b28435 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Peter Baumann <peter.baumann@gmail.com>
    @hangy @siprbaum
    hangy and siprbaum committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e769dfc View commit details
    Browse the repository at this point in the history