fix: incorrectly thrown exception in Directory.CreateSymbolicLink (#…

…1026) Remove incorrectly thrown exception when the target does not exist in Directory.CreateSymbolicLink. The real file system does not throw an exception in this case. > [See here for a succeeding test against the real file system](https://github.com/Testably/Testably.Abstractions/blob/main/Tests/Testably.Abstractions.Tests/FileSystem/Directory/CreateSymbolicLinkTests.cs#L50).
TestableIO · Aug 25, 2023 · ebb5476 · ebb5476
1 parent 00fb310
commit ebb5476
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectory.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectory.cs
@@ -98,12 +98,6 @@ public override IFileSystemInfo CreateSymbolicLink(string path, string pathToTar
                 throw CommonExceptions.FileAlreadyExists(nameof(path));
             }
 
-            var targetExists = Exists(pathToTarget);
-            if (!targetExists)
-            {
-                throw CommonExceptions.FileNotFound(pathToTarget);
-            }
-
             mockFileDataAccessor.AddDirectory(path);
             mockFileDataAccessor.GetFile(path).LinkTarget = pathToTarget;
 

diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectorySymlinkTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectorySymlinkTests.cs
@@ -184,18 +184,18 @@ public void MockDirectory_CreateSymbolicLink_ShouldFailIfPathExists()
         }
 
         [Test]
-        public void MockDirectory_CreateSymbolicLink_ShouldFailIfTargetDoesNotExist()
+        public void MockDirectory_CreateSymbolicLink_ShouldNotFailIfTargetDoesNotExist()
         {
             // Arrange
             var fileSystem = new MockFileSystem();
             string path = XFS.Path(@"C:\Folder\foo");
             string pathToTarget = XFS.Path(@"C:\Target");
 
             // Act
-            var ex = Assert.Throws<FileNotFoundException>(() => fileSystem.Directory.CreateSymbolicLink(path, pathToTarget));
+            var fileSystemInfo = fileSystem.Directory.CreateSymbolicLink(path, pathToTarget);
 
             // Assert
-            Assert.That(ex.Message.Contains(pathToTarget));
+            Assert.IsTrue(fileSystemInfo.Exists);
         }
 
         [Test]