-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiff imagery provider #6748
Closed
Closed
Tiff imagery provider #6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karma-sauce-launcher was causing some build errors and we dont use it
These copied and modified from MapboxVectorTileImageryProvider etc
Here is the link to a publicly available COG on AWS public data - its positioned over Uluru which is useful for testing draping over terrain: url: "https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/52/J/FS/2023/5/S2A_52JFS_20230501_0_L2A/TCI.tif", |
Also add @ts-nocheck to all files, as this developed without strict mode
We now have tiff-imagery-provider in ThirdParty folder
Also modified README with instructions how to use proj defs
Change path to TIFFImageryProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #156
Implement support for Cloud Optimised Geotiffs in Terria.
Added a new dataType 'cog'.
Implement by modifying the MIT licensed library at https://github.com/hongfaqiu/TIFFImageryProvider
Test me
Use this CI link with gist catalog to test:
http://ci.terria.io/tiff-imagery-provider-support/#clean&https://gist.githubusercontent.com/staffordsmith83/ed48ca27d1c4c8d36d130ce6a8098fd7/raw/16206b8e9e114af8e02f5e5082cf935fd3e1281c/example_cogs_catalog.json
Go to Explore map data and add any COG that is in the gist catalog.
Wait for cog to load.
Try 2D and 3D mode.
Try clicking on a point to get the raw raster values.
Also try adding a COG manually, Explore Map Data>My Data> Add Web Data and paste in link to any publicly available COG online. You could use the the Uluru Sentinel image used for testing: https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/52/J/FS/2023/5/S2A_52JFS_20230501_0_L2A/TCI.tif
You should be able to select Cloud Optimised Geotiff as the data type.
TODO
Numerous bug fixes and feature improvements required, see https://github.com/TerriaJS/product/issues/156#issuecomment-1583705900
Checklist
- [ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)- [ ] I've updated relevant documentation indoc/
.