Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiff imagery provider #6748

Closed
wants to merge 11 commits into from
Closed

Tiff imagery provider #6748

wants to merge 11 commits into from

Conversation

staffordsmith83
Copy link
Contributor

@staffordsmith83 staffordsmith83 commented Apr 3, 2023

What this PR does

Fixes #156
Implement support for Cloud Optimised Geotiffs in Terria.

Added a new dataType 'cog'.
Implement by modifying the MIT licensed library at https://github.com/hongfaqiu/TIFFImageryProvider

Test me

Use this CI link with gist catalog to test:
http://ci.terria.io/tiff-imagery-provider-support/#clean&https://gist.githubusercontent.com/staffordsmith83/ed48ca27d1c4c8d36d130ce6a8098fd7/raw/16206b8e9e114af8e02f5e5082cf935fd3e1281c/example_cogs_catalog.json

Go to Explore map data and add any COG that is in the gist catalog.
Wait for cog to load.

Try 2D and 3D mode.

Try clicking on a point to get the raw raster values.

Also try adding a COG manually, Explore Map Data>My Data> Add Web Data and paste in link to any publicly available COG online. You could use the the Uluru Sentinel image used for testing: https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/52/J/FS/2023/5/S2A_52JFS_20230501_0_L2A/TCI.tif

You should be able to select Cloud Optimised Geotiff as the data type.

TODO

Numerous bug fixes and feature improvements required, see https://github.com/TerriaJS/product/issues/156#issuecomment-1583705900

  • Unit Tests

Checklist

- [ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
- [ ] I've updated relevant documentation in doc/.

  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

Karma-sauce-launcher was causing some build errors and we dont use it
These copied and modified from MapboxVectorTileImageryProvider etc
@staffordsmith83
Copy link
Contributor Author

Here is a better example of how a COG looks when draped over terrain in Cesium - this is working in my local simple Cesium application for testing:
image

@staffordsmith83
Copy link
Contributor Author

Here is the link to a publicly available COG on AWS public data - its positioned over Uluru which is useful for testing draping over terrain: url: "https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/52/J/FS/2023/5/S2A_52JFS_20230501_0_L2A/TCI.tif",

@staffordsmith83 staffordsmith83 marked this pull request as ready for review May 19, 2023 04:22
@staffordsmith83 staffordsmith83 deleted the tiff-imagery-provider branch May 22, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant