Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push mirror of SVN repository to GitHub? #1

Closed
pah opened this issue Mar 31, 2014 · 8 comments
Closed

Push mirror of SVN repository to GitHub? #1

pah opened this issue Mar 31, 2014 · 8 comments
Labels

Comments

@pah
Copy link
Contributor

pah commented Mar 31, 2014

There are a bunch of rapidjson forks available on GitHub already, each with a different set of fixes and with differing histories. See for instance (skipped the ones without any additional fixes/features beyond the current trunk ):

Is there any chance to merge those repositories to be based on a single, "official" SVN mirror here at GitHub? Even if the current upstream development of rapidjson seems to have slowed down, maybe a more collaborative model could help to keep the project alive and to join forces among the current users.

Thanks for your work on rapidjson!

@pah
Copy link
Contributor Author

pah commented Mar 31, 2014

I missed to mention scanlime/rapidjson by @scanlime, which contains a DeepCopy function proposal (somewhat conflicting with my proposal in pah/rapidjson#2).

@rjeczalik
Copy link

+1

@chrismanning
Copy link

An "official" mirror would definitely be a good thing.

I would not recommend using my fork as my changes A) were very inconsistent, B) introduce STL which rapidjson was originally explicit to avoid (for whatever reason), and C) sacrifice a little performance, from replacing some (as I said, very inconsistent) placement news with swaps, IIRC.

I've been using my own BSON library (jbson) for a while which parses JSON directly to BSON with decent performance and a nicer interface which fulfills my needs, so I'm unlikely to work on rapidjson any more.

@pah
Copy link
Contributor Author

pah commented Jun 17, 2014

@miloyip: Thanks for starting to push code to GitHub. Can you please briefly comment on your plans regarding the short-term development of rapidjson? Are you willing to accept pull-requests via GitHub?

My GitHub fork contains a slightly dfifferent git-svn history, correctly attributing the changes to your GitHub account (see svn/trunk branch here). Do you want to adopt this branch as master in the official repository? Otherwise, I would recreate my fork to become a real GitHub fork and start submitting pull-requests for the issues fixed in my repository.

Thanks,
Philipp

@miloyip
Copy link
Collaborator

miloyip commented Jun 17, 2014

@pah I wrote a little bit at this wiki. Solving long-awaited issues should be the first priority. And I hope to finish document and examples in order to make a release. I am open on these plan.
Actually rapidjson is my first open source project and I am lack of experience running it. I will be glad if you can give me advices. Or we can discuss via gtalk or other means.

@pah
Copy link
Contributor Author

pah commented Jun 17, 2014

Yes, I saw the wiki pages. The roadmap mostly covers the longer term development. I'm currently more interested in an efficient way to address the "fixes to open issues", i.e. by reintegrating the patches that are floating around in the Google code issue tracker as well as in the different forks here at GitHub.

I'll drop you a mail with my Gtalk/XMPP/Skype handle, maybe we can come up with a good process to efficiently handle this merging process.

@ArtemGr
Copy link

ArtemGr commented Jun 17, 2014

Glad to see you guys beginning the process of processing the process. : )

@pah
Copy link
Contributor Author

pah commented Jun 25, 2014

@miloyip: As you may have seen, I have now opened several pull-requests with my patches against the new official upstream repo here at GitHub.

The "fixes/xx" pull-requests (#9, #10, #11, #12, #13, #14) are all against the master branch , whereas the "feature/xx" pull-requests are against the dev branch (#15, #16, #17).

Please let me know what you think, I'd happily adjust the changes based on your feedback.

@miloyip miloyip closed this as completed Jul 8, 2014
@xinthose xinthose mentioned this issue Aug 19, 2015
dkorolev added a commit to dkorolev/rapidjson that referenced this issue Jul 24, 2016
miloyip pushed a commit that referenced this issue Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants
@ArtemGr @pah @chrismanning @rjeczalik @miloyip and others