Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework util::Flag #179

Merged
merged 5 commits into from Apr 13, 2022
Merged

Rework util::Flag #179

merged 5 commits into from Apr 13, 2022

Conversation

TedDriggs
Copy link
Owner

@TedDriggs TedDriggs commented Apr 13, 2022 •
edited

  • Add span, to facilitate good custom errors on top of flags
  • Remove trait impls to reduce API surface and align to Rust best practices

Fixes #174

@TedDriggs
Move Flag to its own module
72103df
@TedDriggs
Accept allow_unknown_fields = false
c1875ca 
This removes an inconsistency between containers and variants.
It also removes all internal uses of darling::util::Flag.
@TedDriggs
Add Span to util::Flag, and remove Deref impl
f87ae67 
Remove BitAnd and BitOr ops from Flag
@TedDriggs
Improve Flag documentation
2d28593
@TedDriggs
Add CHANGELOG entry for Flag
62b6e25
@TedDriggs TedDriggs merged commit bb12ae2 into master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve darling::util::Flag
1 participant
@TedDriggs