WIP: Infer default for Option fields #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
commented
Mar 8, 2022
| @@ -7,6 +7,18 @@ use syn::{Ident, Path, Type}; | |||
| use crate::codegen::{DefaultExpression, PostfixTransform}; | |||
| use crate::usage::{self, IdentRefSet, IdentSet, UsesTypeParams}; | |||
|
|
|||
| fn is_option(ty: &Type) -> bool { | |||
There was a problem hiding this comment.
This is something derive_builder and serde also do. Should it be extracted to be part of darling::util?
core/src/codegen/field.rs
Outdated
| @@ -173,7 +197,7 @@ impl<'a> ToTokens for Initializer<'a> { | |||
| } else { | |||
| quote!(#ident: #ident) | |||
| } | |||
| } else if let Some(ref expr) = field.default_expression { | |||
| } else if let Some(ref expr) = self.option_aware_default() { | |||
There was a problem hiding this comment.
Should we do something here to make spans better?
TedDriggs
force-pushed
the
is-option-infer-default
branch
from
b5cf25c
to
aa49417
Compare
Related to #161
TedDriggs
force-pushed
the
is-option-infer-default
branch
from
aa49417
to
7003164
Compare
|
This has been superseded by #177, which is safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #161