Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msys2/mingw to CI #33

Merged
merged 7 commits into from
Jul 1, 2021
Merged

Add msys2/mingw to CI #33

merged 7 commits into from
Jul 1, 2021

Conversation

0x00002a
Copy link
Contributor

This adds a workflow that builds with msys2/mingw on pushes to any branch or pull requests to main. It currently builds with TLS ON/OFF and boost versions 1.74.0 and 1.76.0 (1.75.0 skipped because of #19). The build takes... a while. I'm not sure if thats due to using MSYS Makefiles rather than Ninja or just mingw (on my machine it takes ~15 minutes to compile clean whereas msvc takes 2-3, thats with Ninja). It also uses an external version of spdlog (mingw-w64-x86_64-spdlog) since there was an issue when trying to fetch it via cmake.

Closes: #27

@Tectu
Copy link
Owner

Tectu commented Jun 30, 2021

It also uses an external version of spdlog (mingw-w64-x86_64-spdlog) since there was an issue when trying to fetch it via cmake.

What was the issue? To me this sounds like something very much worth figuring out now rather than later down the road. Especially as this might also happen to other dependencies that might be optionally fetched in the future such as nlohmann::json.

@0x00002a
Copy link
Contributor Author

0x00002a commented Jul 1, 2021

I squashed the commit which had it but here: https://github.com/0x00002a/malloy/runs/2954741185?check_suite_focus=true

   Failed to get the hash for HEAD:

  fatal: ambiguous argument 'HEAD^commit': unknown revision or path not in
  the working tree.

  Use '--' to separate paths from revisions, like this:

  'git <command> [<revision>...] -- [<file>...]'

Might be something up with msys2 git?

@Tectu
Copy link
Owner

Tectu commented Jul 1, 2021

I've actually no idea.
I do use both git from MSYS2 and git installed on native Windows at times. I never ran into this before.

Any chance that this was not a clean build but had some dirt left over, especially in the _deps directory?

@0x00002a
Copy link
Contributor Author

0x00002a commented Jul 1, 2021

That directory isn't cached so no. I too have built it just fine with embedded spdlog on msys2. this might be relevant but I'm not sure how FetchContent actually works so I'm a bit out of my depth here

@Tectu
Copy link
Owner

Tectu commented Jul 1, 2021

I don't even have a wild guess at this point...

If we have no clue at all it might be worth trying to install git as a regular Windows program via the official installer and dropping git from the list of packages to install via MSYS2.

@0x00002a
Copy link
Contributor Author

0x00002a commented Jul 1, 2021

Alright that looks to have fixed it. I removed the git download so it used the one preinstalled by default. No idea what the problem with the msys git actually was though

@Tectu Tectu merged commit 9eecc9c into Tectu:main Jul 1, 2021
@0x00002a 0x00002a deleted the feat-mingw-ci branch July 6, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI for MinGW
2 participants