Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain how to avoid the prettiermageddon when updating #167

Merged
merged 1 commit into from Nov 9, 2020
Merged

Explain how to avoid the prettiermageddon when updating #167

merged 1 commit into from Nov 9, 2020

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Nov 9, 2020 •
edited

Recently prettier got broken badly (see prettier/prettier#9459 and all the related PRs/issues there).

This explains how to avoid that problem when updating templates.

To know if this is the problem you're facing, this is the log that you'd find if you cannot install prettier due to this problem:

plumbum.commands.processes.ProcessExecutionError: Unexpected exit code: 1
Command line: | /usr/bin/git commit --allow-empty -am 'dumb commit 2'
Stderr:       | [INFO] Installing environment for https://github.com/prettier/prettier.
              | [INFO] Once installed this environment will be reused.
              | [INFO] This may take a few minutes...
              | An unexpected error has occurred: CalledProcessError: command: ('/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/bin/node', '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/bin/npm', 'install', '--dev', '--prod', '--ignore-prepublish', '--no-progress', '--no-save')
              | return code: 1
              | expected return code: 0
              | stdout: (none)
              | stderr:
              |     npm WARN install Usage of the `--dev` option is deprecated. Use `--include=dev` instead.
              |     npm ERR! code ERESOLVE
              |     npm ERR! ERESOLVE unable to resolve dependency tree
              |     npm ERR! 
              |     npm ERR! While resolving: prettier@2.1.2
              |     npm ERR! Found: remark-parse@8.0.3
              |     npm ERR! node_modules/remark-parse
              |     npm ERR!   remark-parse@"8.0.3" from the root project
              |     npm ERR! 
              |     npm ERR! Could not resolve dependency:
              |     npm ERR! peer remark-parse@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0" from remark-math@1.0.6
              |     npm ERR! node_modules/remark-math
              |     npm ERR!   remark-math@"1.0.6" from the root project
              |     npm ERR! 
              |     npm ERR! Fix the upstream dependency conflict, or retry
              |     npm ERR! this command with --force, or --legacy-peer-deps
              |     npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
              |     npm ERR! 
              |     npm ERR! See /var/home/yajo/.npm/eresolve-report.txt for a full report.
              |     
              |     npm ERR! A complete log of this run can be found in:
              |     npm ERR!     /var/home/yajo/.npm/_logs/2020-11-09T10_46_07_724Z-debug.log
              |     
              | Check the log at /var/home/yajo/.cache/pre-commit/pre-commit.log

Also, this is the log when executing prettier (after it is installed) in an environment that is also affected by this problem:

Inicializado repositorio Git vacío en /tmp/copier.main.update_diff.7jsj3arb/.git/
pre-commit installed at .git/hooks/pre-commit
Traceback (most recent call last):
  File "/var/home/yajo/.local/bin/copier", line 8, in <module>
    sys.exit(CopierApp.run())
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/cli/application.py", line 577, in run
    inst, retcode = subapp.run(argv, exit=False)
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/cli/application.py", line 572, in run
    retcode = inst.main(*tailargs)
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/copier/cli.py", line 38, in _wrapper
    return method(*args, **kwargs)
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/copier/cli.py", line 306, in main
    self.parent._copy(
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/copier/cli.py", line 174, in _copy
    return copy(
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/copier/main.py", line 148, in copy
    update_diff(conf=conf)
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/copier/main.py", line 267, in update_diff
    git("commit", "--allow-empty", "-am", "dumb commit 2")
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/commands/base.py", line 96, in __call__
    return self.run(args, **kwargs)[1]
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/commands/base.py", line 232, in run
    return p.run()
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/commands/base.py", line 193, in runner
    return run_proc(p, retcode, timeout)
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/commands/processes.py", line 302, in run_proc
    return _check_process(proc, retcode, timeout, stdout, stderr)
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/commands/processes.py", line 22, in _check_process
    proc.verify(retcode, timeout, stdout, stderr)
  File "/var/home/yajo/.local/pipx/venvs/copier/lib64/python3.9/site-packages/plumbum/machines/base.py", line 24, in verify
    raise ProcessExecutionError(
plumbum.commands.processes.ProcessExecutionError: Unexpected exit code: 1
Command line: | /usr/bin/git commit --allow-empty -am 'dumb commit 2'
Stderr:       | forbidden files......................................(no files to check)Skipped
              | black....................................................................Passed
              | pyupgrade................................................................Passed
              | isort except __init__.py.................................................Passed
              | prettier + plugin-xml....................................................Failed
              | - hook id: prettier
              | - exit code: 1
              | 
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | internal/modules/cjs/loader.js:883
              |   throw err;
              |   ^
              | 
              | Error: Cannot find module 'prettier/doc'
              | Require stack:
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js
              | - /var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js
              |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
              |     at Function.Module._load (internal/modules/cjs/loader.js:725:27)
              |     at Module.require (internal/modules/cjs/loader.js:952:19)
              |     at require (internal/modules/cjs/helpers.js:88:18)
              |     at Object.<anonymous> (/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js:1:29)
              |     at Module._compile (internal/modules/cjs/loader.js:1063:30)
              |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
              |     at Module.load (internal/modules/cjs/loader.js:928:32)
              |     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
              |     at Module.require (internal/modules/cjs/loader.js:952:19) {
              |   code: 'MODULE_NOT_FOUND',
              |   requireStack: [
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/embed.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/@prettier/plugin-xml/src/plugin.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/common/load-plugins.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/src/cli/index.js',
              |     '/var/home/yajo/.cache/pre-commit/repow9n8yvh_/node_env-default/lib/node_modules/prettier/bin/prettier.js'
              |   ]
              | }
              | 
              | Trim Trailing Whitespace.................................................Passed
              | Fix End of Files.........................................................Passed
              | Debug Statements (Python)................................................Passed
              | Fix python encoding pragma...............................................Passed
              | Check for case conflicts.................................................Passed
              | Check docstring is first.................................................Passed
              | Check that executables have shebangs.................(no files to check)Skipped
              | Check for merge conflicts................................................Passed
              | Check for broken symlinks............................(no files to check)Skipped
              | Check Xml............................................(no files to check)Skipped
              | Mixed line ending........................................................Passed
              | flake8 except __init__.py................................................Passed
              | flake8 only __init__.py..............................(no files to check)Skipped
              | pylint with optional checks..............................................Passed
              | - hook id: pylint
              | - duration: 1.28s
              | pylint with mandatory checks.............................................Passed
              | eslint...............................................(no files to check)Skipped
              | - hook id: eslint

@Tecnativa TT26674

Explain how to avoid the prettiermageddon when updating
8081735 
Recently prettier got broken badly (see prettier/prettier#9459 and all the related PRs/issues there).

This explains how to avoid that problem when updating templates.
@yajo yajo self-assigned this Nov 9, 2020
@yajo yajo added the automerge Marks the PR to be automatically merged when required checks pass label Nov 9, 2020
@yajo yajo added this to the v2.5.0 milestone Nov 9, 2020
@yajo yajo added the documentation Improvements or additions to documentation label Nov 9, 2020
@github-actions github-actions bot merged commit 9d8dd1b into devel Nov 9, 2020
@github-actions github-actions bot deleted the prettiermaggeddon-faq branch November 9, 2020 12:06
@yajo yajo mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-p-marques joao-p-marques joao-p-marques approved these changes

Assignees

@yajo yajo

Labels
automerge Marks the PR to be automatically merged when required checks pass documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yajo @joao-p-marques