Migrate prettier from prettier/prettier to prettier/pre-commit #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-p-marques
force-pushed
the
fix-prettier-migrate
branch
from
f35ba92
to
4888762
Compare
|
Problem with Still depending on prettier/pre-commit#16 fixed |
|
When prettier/pre-commit#17 and prettier/pre-commit#18 are merged, we can remove the extra dependencies and args. |
yajo
suggested changes
Oct 21, 2020
joao-p-marques
force-pushed
the
fix-prettier-migrate
branch
from
4888762
to
efbc006
Compare
yajo
approved these changes
Oct 21, 2020
yajo
pushed a commit
that referenced
this pull request
Oct 23, 2020
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment. Once those are solved, we can start using the new repo.
yajo
pushed a commit
that referenced
this pull request
Oct 23, 2020
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment. Once those are solved, we can start using the new repo. Updated prettier BTW.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2020
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment. Once those are solved, we can start using the new repo. Updated prettier BTW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See prettier/prettier#9459