Replace proc-macro-error with proc-macro2-diagnostics #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` TRYBUILD=overwrite cargo test ```
```
warning: unnecessary parentheses around match arm expression
--> structopt-derive/src/parse.rs:177:28
|
177 | "about" => (Ok(About(name, None))),
| ^ ^
|
= note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
|
177 - "about" => (Ok(About(name, None))),
177 + "about" => Ok(About(name, None)),
|
warning: unnecessary parentheses around match arm expression
--> structopt-derive/src/parse.rs:178:29
|
178 | "author" => (Ok(Author(name, None))),
| ^ ^
|
help: remove these parentheses
|
178 - "author" => (Ok(Author(name, None))),
178 + "author" => Ok(Author(name, None)),
|
```
```
warning: the following explicit lifetimes could be elided: 'a
--> src/lib.rs:1205:24
|
1205 | fn from_subcommand<'a, 'b>(_sub: (&'b str, Option<&'b clap::ArgMatches<'a>>)) -> Option<Self>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
1205 - fn from_subcommand<'a, 'b>(_sub: (&'b str, Option<&'b clap::ArgMatches<'a>>)) -> Option<Self>
1205 + fn from_subcommand<'b>(_sub: (&'b str, Option<&'b clap::ArgMatches<'_>>)) -> Option<Self>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/lib.rs:1230:24
|
1230 | fn from_subcommand<'a, 'b>(sub: (&'b str, Option<&'b clap::ArgMatches<'a>>)) -> Option<Self> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1230 - fn from_subcommand<'a, 'b>(sub: (&'b str, Option<&'b clap::ArgMatches<'a>>)) -> Option<Self> {
1230 + fn from_subcommand<'b>(sub: (&'b str, Option<&'b clap::ArgMatches<'_>>)) -> Option<Self> {
|
```
proc-macro-error is unmaintained, and structopt-derive is by far its most popular dependent. See https://crates.io/crates/proc-macro-error/reverse_dependencies.
|
@TeXitoi could you have a look please? |
|
That’s a big change for a frozen crate. I’ll try to have a look, but no promise. |
TeXitoi
reviewed
Mar 14, 2024
| @@ -1,18 +1,10 @@ | |||
| error: `#[structopt(raw(...))` attributes are removed in structopt 0.3, they are replaced with raw methods | |||
|
|
|||
| = help: if you meant to call `clap::Arg::raw()` method you should use bool literal, like `raw(true)` or `raw(false)` | |||
| = note: if you need to call `clap::Arg/App::case_insensitive` method you can do it like this: #[structopt(case_insensitive = true)] | |||
There was a problem hiding this comment.
Yes, and one that I've called out here.
imo that effort would be better spent migrating some of the more popular users. |
|
You mean like this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
I realize this crate is deprecated in favor of clap, but it still seems to
enjoy some 10,000-40,000 downloads per day over the past three months. Updating
to syn@2 is likely to have positive effect on compilation time for dependents.
See https://crates.io/crates/structopt-derive for download graphs.