Fix duplication of aliases in subcommands #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue where all top level methods were duplicated for subcommands with fields (see issue TeXitoi#418). For some attributes, such as aliases, this resulted in duplicate output.
This was referenced Oct 16, 2021
|
Thanks |
|
v0.3.24 published |
|
Sorry, bad publication, this PR is in v0.3.25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where all top level methods were duplicated for subcommands with fields (see issue #418). For some attributes, such as aliases, this resulted in duplicate output.
The issue was caused by the fact that for named enum variants
gen_augmentationwas used to generate the clap data, which already parses the attributes, while later onattrs.top_level_methods()was used to parse attributes again, so that the attributes were parsed and generated twice. For some attributes, this merely resulted in the attribute being set twice, which is fairly harmless, but for some attributes, such as aliases, this resulted in the alias being added to the vector of aliases twice, which in turn causes the alias to be printed twice in the help message.Fixes #418