Skip to content

Commit

Permalink
fix(dexie): revert dexie imports hacks
Browse files Browse the repository at this point in the history
  • Loading branch information
JMounier committed Feb 16, 2022
1 parent 0420805 commit 3be3b73
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
2 changes: 2 additions & 0 deletions config/webpack.config.base.js
Expand Up @@ -158,6 +158,8 @@ const makeBaseConfig = ({ mode, target, react, hmre, devtool, plugins, tsconfig
'@tanker/verification-ui': path.resolve(__dirname, '../packages/verification-ui/src/index.tsx'),
'@tanker/filekit': path.resolve(__dirname, '../packages/filekit/src/index.ts'),
'@tanker/functional-tests': path.resolve(__dirname, '../packages/functional-tests/src/index.ts'),
// dexie resolves to 'dist/modern/dexie.mjs' by default, which is not IE11 compatible
// 'dist/dexie.js' is compatible
dexie: path.resolve(__dirname, '../node_modules/dexie/dist/dexie.js'),
},
extensions,
Expand Down
12 changes: 0 additions & 12 deletions run-ci.py
@@ -1,5 +1,4 @@
import argparse
import json
import os
import re
import shutil
Expand Down Expand Up @@ -241,22 +240,11 @@ def deploy_sdk(*, version: str) -> None:
publish_npm_package(package_name, version)


def patch_dexie_resolution(*, test_dir: Path) -> None:
# Freeze dexie version until https://github.com/dfahlander/Dexie.js/issues/1439 is fixed
package = test_dir / "package.json"
with open(package, "r+") as package_file:
data = json.load(package_file)
package_file.seek(0) # rewind
data["resolutions"] = {"dexie": "3.0.3"}
json.dump(data, package_file, indent=4)


def test_deploy(*, version: str) -> None:
test_dir = Path("test")
index_file = test_dir / "index.js"
test_dir.mkdir()
tankerci.js.run_yarn("init", "--yes", cwd=test_dir)
patch_dexie_resolution(test_dir=test_dir)
tankerci.js.run_yarn("add", f"@tanker/client-browser@{version}", cwd=test_dir)
index_file.write_text('require("@tanker/client-browser");')
tankerci.run("node", "index.js", cwd=test_dir)
Expand Down

0 comments on commit 3be3b73

Please sign in to comment.