Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import-profile): Import user profile and docs to device #3701

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

evansdianga
Copy link
Contributor

Description


Download user profile and corresponding docs to device.
Allow user to retry on failure or resume

Type of Change

  • New feature (non-breaking change which adds functionality)

Evans Dianga added 2 commits May 14, 2024 21:44
Download user profile and corresponding docs to device.
Allow user to retry on failure or resume

Refs #3696
@evansdianga evansdianga requested a review from esurface May 15, 2024 06:53
Copy link
Contributor

@esurface esurface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evansdianga From my read through the code, it looks like the submit and retry buttons run the same code and are disabled/enabled by the same state. Do we need both or can the retry be triggered by hitting the submit button again after ERROR?

Evans Dianga added 4 commits May 24, 2024 12:48
…ve UI

- increase docs per call to 1000
- syncing state should only be set when the short-code is found in the remote db
- Send minimal profile data to the client

Refs Tangerine-Community/Tangerine#ticket number
- Sync text should reflect that the docs are already synced
- Navigation should be the very last item after successful sync

Refs Tangerine-Community/Tangerine#ticket number
- Add error messages and retry logic
- Notify user when record with the supplied import code is not found

Refs #3696
Copy link
Contributor

@esurface esurface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esurface esurface merged commit 99f6289 into release/v3.31.0 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants