Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel (fix for #3962) #3984

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Update babel (fix for #3962) #3984

merged 1 commit into from
Jun 6, 2022

Conversation

markwoon
Copy link

Per #3962:

  • Update @babel/core and @babel/plugin-transform-regenerator to 7.18.0, so that the generated code doesn't rely on the regeneratorRuntime global anymore.

Babel config already uses babel-transform-runtime.

@vercel
Copy link

vercel bot commented May 31, 2022

@markwoon is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@markwoon
Copy link
Author

@nicolo-ribaudo Can you confirm that when you say

Add @babel/runtime to your Babel config, which loads the helpers from @babel/runtime (including regeneratorRuntime)

You mean add babel-transform-runtime to babel config? If not, how exactly do you do so?

@nicolo-ribaudo
Copy link

nicolo-ribaudo commented Jun 1, 2022

Yes, I meant plugin-transform-runtime. However, it's commented out in the Babel config.

@tannerlinsley
Copy link
Collaborator

Anything left on this PR?

@markwoon
Copy link
Author

markwoon commented Jun 6, 2022

PR is complete.

@eliasrodeloso
Copy link

@tannerlinsley hey! Thank you for your hard work on this one. I have a project recently merged to Vite, and I'm founding this issue. I was wondering if this PR was in any release. I wasn't able to find the release where this was released. Worth mentioning I'm not able to update this to v8.

@vuxor
Copy link

vuxor commented Mar 14, 2023

I would agree with @eliasrodeloso . The latest release in major version 7 does not include this fix.
@tannerlinsley any plans to make a new release with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants