New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Svelte adapter #31
base: main
Are you sure you want to change the base?
Conversation
For the setup of the whole package I mainly copied and pasted from the vue example and svelte-query. I hope the setup is fine. |
This looks great to me, but I'm not a Svelte-spert admittedly 😅 Tagging in @LukeHagar to review the Svelte code, as he was offering to help out with a Svelte adapter for Forms PS I'm so sorry I missed this PR - I just didn't see it at the time; no excuses. Sorry! |
I just wanted to follow up here, this looks like a good implementation, and I'm glad to see you using the existing Svelte store functions. That being said I think this will end up changing once runes come about. |
@LukeHagar That's what we talked about yesterday in the discord. I played a bit around with runes and that's what I got so far: But the tooling around svelte-5 is... well not there yet and I can't get svelte-package to output types for index.svelte.ts files or tests working @crutchcorn does it make sense to release the adapter in it's current form for svelte-4 or should we just wait until svelte-5 arrives? |
Let's hold off for Svelte 5 - apologies for sending us all down this goose chase until then 😅😅 |
Hey there, |
…k-main # Conflicts: # .gitignore # babel.config.cjs # docs/installation.md # package.json # packages/solid-store/src/index.ts # packages/solid-store/vitest.config.ts # pnpm-lock.yaml
Sounds great to me! |
This PR:
Regarding the questions in the issue:
Note: I just copy and pasted the shallow function - it might be worth refactoring that into the core package?
Closes #4