New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(eslint-plugin-query): Migrate to ESLint v9 with Flat Config Support #7253
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cf11b6a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
Also note how |
Thanks for this. We'd definitely need to update docs and show how to use the plugin both for flat config and the v8 syntax. |
lockfile seems to be outdated:
|
The root package.json requires all packages to use the same ESLint version. Lines 83 to 89 in fca5e7d
Besides the ESLint Plugin - which I updated to v9 - eslint v8 is currently depended on by examples/react/shadow-dom and examples/react/basic-typescript which need to be fixed. Updating the examples to Flat Config is blocked by the upstream react plugin issues though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf11b6a:
|
I think this has to wait until it is offically supported by The tests are still failing because of differences how rule definitions work for the flat config format, but |
This PR is a starting point to add support for the newly released ESLint v9 as well as exposing a new
flat/recommended
to be used ineslint.config.js
.Edit: I noticed the separate
flat/recommended
config may not be necessary given it exports the same rules as therecommended
config anyway.I confirmed this works on my project testing only withbut haven't tested the oldeslint@9
,recommended
config, neither did I test witheslint@8
.Resources
I used the following resources to find out which changes to make
To Be Discussed
flat
config is required to support both formats.exports
in packages.json from./dist/esm/index.js
to./dist/esm/src/index.js
to use the package installed from a directory. Probably not an issue if it works in ci, but wanted to mention it just in case.TODO
Related Issues