Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useQuery): fix tracked queries and error boundaries #2993

Merged
merged 1 commit into from Nov 20, 2021
Merged

fix(useQuery): fix tracked queries and error boundaries #2993

merged 1 commit into from Nov 20, 2021

Commits on Nov 20, 2021

  1. fix(useQuery): fix tracked queries and error boundaries 

    if you useErrorBoundary, you're likely not observing the error, because you're not using the returned error field - the ErrorBoundary handles the error for you. So when the actual error then happens, we don't inform the observer about it, because we're only informing them if a prop has changed that they are interested in, resulting in the error boundary never being shown.

The solution would be to always track the error property if you've set useErrorBoundary
    @TkDodo
    TkDodo committed Nov 20, 2021
    Copy the full SHA
    e88631d View commit details
    Browse the repository at this point in the history