Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(QueryObserver): track queries as default #2987

Merged
merged 13 commits into from Nov 20, 2021
Merged

feat(QueryObserver): track queries as default #2987

merged 13 commits into from Nov 20, 2021

Commits on Nov 18, 2021

  1. feat(Query Options): remove notifyOnChangePropsExclusion 

    - remove related code from queryObserver
- remove type def
- remove related tests
    @babycourageous
    babycourageous committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    66bf3ec View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. docs(Query Options): update notifyOnChangePropsExclusion sections 

    - remove from api references
- add to v4 migration guide
    @babycourageous
    babycourageous committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    3b2af74 View commit details
    Browse the repository at this point in the history

  2. feat(QueryObserver): "tracked" as default behavior 

    - remove "tracked" completely if notifyOnChangeProps is not defined, behave as v3 "tracked"
- add `notifyOnChangeProps: 'all' to opt out of the smart tracking

TODO: Now that default behavior has changed, work out the failed tests. Which parts to change for current ones and possibly write new ones.
    @babycourageous
    babycourageous committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    49069f7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v4' of github.com:tannerlinsley/react-query into featur… 

    …e/queries-default-tracked
    @babycourageous
    babycourageous committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    5634c80 View commit details
    Browse the repository at this point in the history

  4. test(useQuery): adjust tests to pass for notifyOnChangeProps udpate

    @babycourageous
    babycourageous committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    74d72ed View commit details
    Browse the repository at this point in the history

  5. test(useInfiniteQuery): adjust tests to pass for notifyOnChangeProps … 

    …udpate
    @babycourageous
    babycourageous committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    497d4ac View commit details
    Browse the repository at this point in the history

  6. test(QueryResetErrorBoundary): adjust tests to pass for notifyOnChang… 

    …eProps udpate
    @babycourageous
    babycourageous committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    a34b472 View commit details
    Browse the repository at this point in the history

  7. refactor(QueryObserver): use nullish coalescing operator 

    much cleaner than the negated if I started with
    @babycourageous
    babycourageous committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    17b2197 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. Merge branch 'v4' into feature/queries-default-tracked

    @babycourageous
    babycourageous committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    c5eb322 View commit details
    Browse the repository at this point in the history

  2. test(QueryResetErrorBoundary): remove "tracked" from test

    @babycourageous
    babycourageous committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    c57e400 View commit details
    Browse the repository at this point in the history

  3. revert: test(QueryResetErrorBoundary): adjust tests to pass for notif… 

    …yOnChaneProps udpate

This reverts commit a34b472.

The changes are not necessary after PR TanStack#2993 fix.
    @babycourageous
    babycourageous committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    fcd615c View commit details
    Browse the repository at this point in the history

  4. refactor(QueryObserver): combine prop checks

    @babycourageous
    babycourageous committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    0f4bf90 View commit details
    Browse the repository at this point in the history

  5. docs(notifyOnChangeProps): update docs to reflect new api

    @babycourageous
    babycourageous committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    10215b0 View commit details
    Browse the repository at this point in the history