Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2901 improve devtools a11y #2947

Merged
merged 3 commits into from Nov 17, 2021

Commits on Nov 15, 2021

  1. fix(devtools): improve devtools container a11y

    default element changes to aside from footer because aside
    represents a portion of a document whose content is only indirectly
    related to the document's main content.
    aria-label is also added to replace the text "generic" in a11y tree.
    Andrewnt219 committed Nov 15, 2021
    Copy the full SHA
    c97f184 View commit details
    Browse the repository at this point in the history
  2. fix(devtools): add aria to devtools toggle button

    aria-expanded indicates open/closed of the menu
    aria-haspopup indicates this is a menu button
    aria-controls to link to the menu, also added aria-label on the menu to
    label it.
    
    Read more: https://www.w3.org/TR/wai-aria-practices/examples/menu-button/menu-button-links.html
    Andrewnt219 committed Nov 15, 2021
    Copy the full SHA
    43093bf View commit details
    Browse the repository at this point in the history
  3. fix(devtools): menuitem are visible in a11y tree in closed devtools

    This is because the element is just hidden visually, but is still inside
    the DOM. The added conditional display only affects the inner container,
    which means the animation of opening/closing is reserved.
    Andrewnt219 committed Nov 15, 2021
    Copy the full SHA
    672aee5 View commit details
    Browse the repository at this point in the history