refactor: disallow implicit returns (#4640)

close /issues/4607

packages/query-async-storage-persister/src/index.ts

@@ -55,6 +55,7 @@ export const createAsyncStoragePersister = ({
     ): Promise<Error | undefined> => {
       try {
         await storage.setItem(key, serialize(persistedClient))
+        return
       } catch (error) {
         return error as Error
       }

packages/query-core/src/focusManager.ts

@@ -28,6 +28,7 @@ export class FocusManager extends Subscribable {
           window.removeEventListener('focus', listener)
         }
       }
+      return
     }
   }
 

packages/query-core/src/infiniteQueryBehavior.ts

@@ -193,6 +193,7 @@ export function hasNextPage(
       nextPageParam !== false
     )
   }
+  return
 }
 
 /**
@@ -211,4 +212,5 @@ export function hasPreviousPage(
       previousPageParam !== false
     )
   }
+  return
 }

packages/query-core/src/onlineManager.ts

@@ -28,6 +28,8 @@ export class OnlineManager extends Subscribable {
           window.removeEventListener('offline', listener)
         }
       }
+
+      return
     }
   }
 

packages/query-core/src/retryer.ts

@@ -185,6 +185,7 @@ export function createRetryer<TData = unknown, TError = unknown>(
             if (shouldPause()) {
               return pause()
             }
+            return
           })
           .then(() => {
             if (isRetryCancelled) {

packages/query-core/src/utils.ts

@@ -418,6 +418,7 @@ export function getAbortController(): AbortController | undefined {
   if (typeof AbortController === 'function') {
     return new AbortController()
   }
+  return
 }
 
 export function replaceData<

packages/query-sync-storage-persister/src/index.ts

@@ -46,6 +46,7 @@ export function createSyncStoragePersister({
     const trySave = (persistedClient: PersistedClient): Error | undefined => {
       try {
         storage.setItem(key, serialize(persistedClient))
+        return
       } catch (error) {
         return error as Error
       }

packages/react-query-devtools/src/devtools.tsx

@@ -244,6 +244,7 @@ export function ReactQueryDevtools({
         ref.removeEventListener('transitionend', handlePanelTransitionEnd)
       }
     }
+    return
   }, [isResolvedOpen])
 
   React.useEffect(() => {
@@ -296,6 +297,7 @@ export function ReactQueryDevtools({
         }
       }
     }
+    return
   }, [isResolvedOpen, panelPosition, devtoolsHeight, devtoolsWidth])
 
   const { style: panelStyle = {}, ...otherPanelProps } = panelProps

packages/react-query-devtools/src/useMediaQuery.ts

@@ -6,6 +6,7 @@ export default function useMediaQuery(query: string): boolean | undefined {
     if (typeof window !== 'undefined') {
       return window.matchMedia(query).matches
     }
+    return
   })
 
   // Watch for changes
@@ -26,6 +27,7 @@ export default function useMediaQuery(query: string): boolean | undefined {
         matcher.removeListener(onChange)
       }
     }
+    return
   }, [isMatch, query, setIsMatch])
 
   return isMatch

packages/vue-query/src/__tests__/useInfiniteQuery.types.test.tsx

@@ -32,6 +32,7 @@ describe('Discriminated union return type', () => {
           true
         return result
       }
+      return
     })
   })
 
@@ -47,6 +48,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<null, typeof query.error>> = true
         return result
       }
+      return
     })
   })
 
@@ -62,6 +64,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<undefined, typeof query.data>> = true
         return result
       }
+      return
     })
   })
 
@@ -77,6 +80,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<unknown, typeof query.error>> = true
         return result
       }
+      return
     })
   })
 })

packages/vue-query/src/__tests__/useMutation.types.test.tsx

@@ -25,6 +25,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<string, typeof mutation.data>> = true
         return result
       }
+      return
     })
   })
 
@@ -38,6 +39,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<null, typeof mutation.error>> = true
         return result
       }
+      return
     })
   })
 
@@ -51,6 +53,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<undefined, typeof mutation.data>> = true
         return result
       }
+      return
     })
   })
 
@@ -64,6 +67,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<unknown, typeof mutation.error>> = true
         return result
       }
+      return
     })
   })
 })

packages/vue-query/src/__tests__/useQuery.types.test.tsx

@@ -28,6 +28,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<string, typeof query.data>> = true
         return result
       }
+      return
     })
   })
 
@@ -43,6 +44,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<null, typeof query.error>> = true
         return result
       }
+      return
     })
   })
 
@@ -58,6 +60,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<undefined, typeof query.data>> = true
         return result
       }
+      return
     })
   })
 
@@ -73,6 +76,7 @@ describe('Discriminated union return type', () => {
         const result: Expect<Equal<unknown, typeof query.error>> = true
         return result
       }
+      return
     })
   })
 })

tsconfig.base.json

@@ -7,7 +7,7 @@
     "allowSyntheticDefaultImports": true,
     "strict": true,
     "noImplicitAny": true,
-    "noImplicitReturns": false,
+    "noImplicitReturns": true,
     "noImplicitThis": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,