Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(devtools): improve devtools a11y (#2947)
* fix(devtools): improve devtools container a11y default element changes to aside from footer because aside represents a portion of a document whose content is only indirectly related to the document's main content. aria-label is also added to replace the text "generic" in a11y tree. * fix(devtools): add aria to devtools toggle button aria-expanded indicates open/closed of the menu aria-haspopup indicates this is a menu button aria-controls to link to the menu, also added aria-label on the menu to label it. Read more: https://www.w3.org/TR/wai-aria-practices/examples/menu-button/menu-button-links.html * fix(devtools): menuitem are visible in a11y tree in closed devtools This is because the element is just hidden visually, but is still inside the DOM. The added conditional display only affects the inner container, which means the animation of opening/closing is reserved.
- Loading branch information
16131c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs: