-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade react-scripts
to v5 (Create React App 5)
#368
Conversation
✅ Deploy Preview for talisman-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for talisman-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
23af4a7
to
5074f14
Compare
TODO: app have too many typescript errors to be fixable in one PR remove once all is fixed
5074f14
to
a554e8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intention is to make it pretty painful then I guess it'll work, I'm getting lots of typing errors running this locally. We could implement the suggestion to suppress errors on each file and knock them off after the merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it 👍
Changes
pako
bugs that are breaking Babel:Close #336