Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade react-scripts to v5 (Create React App 5) #368

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

tien
Copy link
Member

@tien tien commented Nov 6, 2022

Changes

Close #336

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for talisman-web ready!

Name Link
🔨 Latest commit a554e8a
🔍 Latest deploy log https://app.netlify.com/sites/talisman-web/deploys/6368631edc62d800099b10af
😎 Deploy Preview https://deploy-preview-368--talisman-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for talisman-storybook ready!

Name Link
🔨 Latest commit a554e8a
🔍 Latest deploy log https://app.netlify.com/sites/talisman-storybook/deploys/6368631e9ce2310008510c0e
😎 Deploy Preview https://deploy-preview-368--talisman-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tien tien force-pushed the build/react-scripts-5 branch 4 times, most recently from 23af4a7 to 5074f14 Compare November 7, 2022 01:44
Copy link
Contributor

@jonathanpdunne jonathanpdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intention is to make it pretty painful then I guess it'll work, I'm getting lots of typing errors running this locally. We could implement the suggestion to suppress errors on each file and knock them off after the merge?

Copy link
Contributor

@jonathanpdunne jonathanpdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it 👍

@tien tien merged commit 9414af6 into main Nov 7, 2022
@tien tien deleted the build/react-scripts-5 branch November 7, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade react-script to v5
2 participants