Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ARCH-737): add ESM support #5263

Draft
wants to merge 51 commits into
base: master
Choose a base branch
from
Draft

feat(ARCH-737): add ESM support #5263

wants to merge 51 commits into from

Conversation

jmfrancois
Copy link
Collaborator

What is the problem this PR is trying to solve?

our lib are in the CommonJS format.
We want to move forward by using vite as bundler which is the common mainstream tool today to work on react.
To achieve that we need to modernize our libraries and start to push ESM format.

What is the chosen solution to this problem?

  • add script to start the playground with vite
  • add output esm configuration to all ui libraries (packages and fork)

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 9, 2024 08:58 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 9, 2024 08:58 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 9, 2024 08:58 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.2% (1272/1426) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 90.81% (5518/6076) 81.84% (3192/3900) 88.19% (1390/1576)
containers Coverage: 84%
 83.71% (1388/1658) 74.81% (692/925) 75.17% (327/435)
dataviz Coverage: 85%
 85.44% (323/378) 66.66% (160/240) 75.79% (119/157)
design-system Coverage: 67%
 67% (1005/1500) 50.47% (527/1044) 54.54% (216/396)
faceted-search Coverage: 85%
 85.69% (677/790) 79.31% (303/382) 82.63% (238/288)
flow-designer Coverage: 70%
 70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
 85.42% (1630/1908) 75.45% (922/1222) 84.24% (460/546)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (73/73) 90.9% (10/11) 100% (24/24)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited

Size Change: -651 kB (-4%)

Total Size: 17 MB

Filename Size Change
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 205 kB -71.7 kB (-26%) 🎉
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 11.3 kB -43.3 kB (-79%) 🏆
./packages/cmf/dist/TalendReactCmf.js 735 kB -70.8 kB (-9%) ✅
./packages/cmf/dist/TalendReactCmf.min.js 108 kB -43 kB (-28%) 🎉
./packages/components/dist/TalendReactComponents.js 4.63 MB -217 kB (-4%)
./packages/components/dist/TalendReactComponents.min.js 1.24 MB -49.8 kB (-4%)
./packages/containers/dist/TalendReactContainers.js 634 kB -71.1 kB (-10%) 👏
./packages/containers/dist/TalendReactContainers.min.js 92.5 kB -43.2 kB (-32%) 🎉
./packages/design-system/dist/TalendDesignSystem.js 1.36 MB -71.1 kB (-5%) ✅
./packages/design-system/dist/TalendDesignSystem.min.js 244 kB -43.1 kB (-15%) 👏
./packages/faceted-search/dist/TalendReactFacetedSearch.js 541 kB -210 kB (-28%) 🎉
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 100 kB -48.2 kB (-33%) 🎉
./packages/forms/dist/TalendReactForms.js 1.45 MB +390 kB (+37%) 🚨
./packages/forms/dist/TalendReactForms.min.js 265 kB -58.8 kB (-18%) 👏
./packages/theme/dist/bootstrap.css 171 kB -470 B (0%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.15 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.33 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 672 B +77 B (+13%) ⚠️
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 695 B +81 B (+13%) ⚠️
./packages/cmf-router/dist/TalendReactCmfRouter.js 163 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.25 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.8 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.29 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.35 kB 0 B
./packages/components/dist/TalendReactComponents.css 397 kB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.21 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 212 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.29 kB 0 B
./packages/containers/dist/TalendReactContainers.css 2.99 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.4 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.78 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.45 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 28.1 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 370 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.15 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 12.2 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 59.5 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 332 kB +22 B (0%)
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.57 kB +77 B (+5%) 🔍
./packages/design-system/dist/TalendDesignSystem.min.css 215 kB +22 B (0%)
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.61 kB +81 B (+5%) 🔍
./packages/design-tokens/dist/TalendDesignTokens.css 79.1 kB +20 B (0%)
./packages/design-tokens/dist/TalendDesignTokens.js 39.7 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 75 kB +20 B (0%)
./packages/design-tokens/dist/TalendDesignTokens.min.js 33.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 19.1 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.54 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 6.28 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.59 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 50.7 kB -25 B (0%)
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.25 kB 0 B
./packages/forms/dist/TalendReactForms.css 19.7 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.36 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 6.13 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.39 kB 0 B
./packages/http/dist/TalendHttp.js 24.8 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 5.31 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 26.8 kB 0 B
./packages/icons/dist/react.esm.js 614 kB +14 B (0%)
./packages/icons/dist/react.js 654 kB +15 B (0%)
./packages/icons/dist/talend-icons-webfont.css 18.3 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 786 kB +17 B (0%)
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 636 kB +15 B (0%)
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 14.5 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 134 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 21 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.css 2.41 kB 0 B
./packages/stepper/dist/TalendReactStepper.js 97 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 1.27 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.css 1.2 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js 9.37 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 1.31 kB 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 384 B 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.5 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 14:17 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 14:17 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 14:17 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 15:15 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 15:15 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 15:15 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 16:08 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 9, 2024 16:08 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 14:19 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 14:19 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 14:19 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 14:19 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 15:41 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 15:41 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 15:41 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 15:41 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 16:28 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 16:28 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 16:28 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 16:28 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 23, 2024 16:28 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

5263

:octocat: Demo is available here

@smouillour smouillour temporarily deployed to pull_request_unsafe April 26, 2024 13:10 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 26, 2024 13:10 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 26, 2024 13:10 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 26, 2024 13:10 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe May 6, 2024 15:27 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe May 6, 2024 15:27 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe May 6, 2024 15:27 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe May 6, 2024 15:27 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe May 6, 2024 15:27 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmfrancois @smouillour