feat: what do next ? #4957

jmfrancois · 2023-10-24T15:26:44Z

What is the problem this PR is trying to solve?

We have duplicates components between react-components and design-system

What is the chosen solution to this problem?

start the migration by remove duplicate components and fix all usage.

fix usage in @talend/react-components itself
fix storybook usage in @talend/react-components
fix usage in the rest of the repository
fix usage in all storybook
create changeset files
write down migration guide

What is the impact on the size ?

minified CSS: from 210kB to 178kB
minified JS: from 661kB to 611kB

react-components	design-system
Breadcrumbs	Breadcrumbs
Checkbox	Form.Checkbox
CollapsiblePanel	CollapsiblePanel
Drawer	FloatingDrawer
Icon	Icon
IconsProvider	IconsProvider
OverlayTrigger	Popover
Skeleton	Skeleton*
Status	Status
TabBar	Tabs
Tag	Tag
Toggle	Form.ToggleSwitch
TooltipTrigger	Tooltip

Two options for the strategy:

Breaking changes (like here)
Keep compatibility: Create proxy so no code change is needed

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-10-25T08:39:54Z

4957

Demo is available here

github-actions · 2023-10-25T09:22:08Z

Size Change: -276 kB (-2%)

Total Size: 13.1 MB

Filename	Size	Change
`./packages/components/dist/TalendReactComponents.css`	360 kB	-42.8 kB (-11%)	👏
`./packages/components/dist/TalendReactComponents.js`	2.82 MB	-155 kB (-5%)	✅
`./packages/components/dist/TalendReactComponents.min.css`	181 kB	-28.8 kB (-14%)	👏
`./packages/components/dist/TalendReactComponents.min.js`	623 kB	-38.4 kB (-6%)	✅
`./packages/containers/dist/TalendReactContainers.js`	530 kB	-9.2 kB (-2%)
`./packages/containers/dist/TalendReactContainers.min.js`	104 kB	-1.12 kB (-1%)

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	104 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.8 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js`	637 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js`	121 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	372 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	63.6 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.18 kB
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB
`./packages/design-system/dist/TalendDesignSystem.js`	1.18 MB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.43 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB
`./packages/design-system/dist/TalendDesignSystem.min.js`	236 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.48 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.8 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	453 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.5 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	103 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	51.5 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	39.3 kB
`./packages/forms/dist/TalendReactForms.js`	780 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.37 kB
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB
`./packages/forms/dist/TalendReactForms.min.js`	205 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.41 kB
`./packages/http/dist/TalendHttp.js`	24.9 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.1 kB
`./packages/icons/dist/react.esm.js`	585 kB
`./packages/icons/dist/react.js`	623 kB
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	752 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	606 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.4 kB
`./packages/jsfc/dist/index.js`	86.8 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB
`./packages/stepper/dist/TalendReactStepper.js`	97.4 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	9.64 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB
`./packages/theme/dist/bootstrap.css`	172 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

jmfrancois added 2 commits October 24, 2023 17:17

chore: drop deprecated components

0777e5d

chore: start cleanup

516ce59

jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 15:26 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 24, 2023 15:26 — with GitHub Actions Failure

jmfrancois changed the title ~~Jmfrancois/feat/next bootstrap~~ feat: what do next bootstrap Oct 24, 2023

jmfrancois changed the title ~~feat: what do next bootstrap~~ feat: what do next ? Oct 24, 2023

fix: imports

310af2c

jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 15:43 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 24, 2023 15:43 — with GitHub Actions Failure

fix: import in react components

ffb0c35

jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 19:58 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 24, 2023 19:58 — with GitHub Actions Failure

fix: import in react components

fbafc1d

jmfrancois temporarily deployed to pull_request_unsafe October 25, 2023 06:55 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 25, 2023 06:55 — with GitHub Actions Failure

jmfrancois added 3 commits October 25, 2023 10:07

fix: import in react components

c6722ea

fix: stories start !!

766f898

fix: few stories

520c94b

jmfrancois temporarily deployed to pull_request_unsafe October 25, 2023 08:29 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 25, 2023 08:29 — with GitHub Actions Error

jmfrancois temporarily deployed to pull_request_unsafe October 25, 2023 08:29 — with GitHub Actions Inactive

chore: remove breadcrumbs

8c41786

jmfrancois temporarily deployed to pull_request_unsafe October 25, 2023 08:50 — with GitHub Actions Inactive

chore: remove Checkbox

4c8b566

jmfrancois temporarily deployed to pull_request_unsafe October 25, 2023 09:36 — with GitHub Actions Inactive

Merge branch 'master' into jmfrancois/feat/next-bootstrap

3814585

jmfrancois temporarily deployed to pull_request_unsafe October 25, 2023 14:32 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: what do next ? #4957

feat: what do next ? #4957

jmfrancois commented Oct 24, 2023 •

edited

github-actions bot commented Oct 25, 2023

github-actions bot commented Oct 25, 2023 •

edited

feat: what do next ? #4957

Are you sure you want to change the base?

feat: what do next ? #4957

Conversation

jmfrancois commented Oct 24, 2023 • edited

github-actions bot commented Oct 25, 2023

github-actions bot commented Oct 25, 2023 • edited

jmfrancois commented Oct 24, 2023 •

edited

github-actions bot commented Oct 25, 2023 •

edited