Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade react-transition-group #4537

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jmfrancois
Copy link
Collaborator

What is the problem this PR is trying to solve?

yarn why:

- "_project_#@talend#react-components#react-transition-group"
- "_project_#@talend#react-stepper#react-transition-group"
- "_project_#@talend#react-bootstrap#react-transition-group"
- "_project_#@talend#react-components#recharts#react-smooth" depends on it.

What is the chosen solution to this problem?

  • upgrade direct deps
  • upgrade react-overlays
  • update code apply breaking changes

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

dependabot bot and others added 2 commits January 9, 2023 15:06
Bumps [react-transition-group](https://github.com/reactjs/react-transition-group) from 2.9.0 to 4.4.5.
- [Release notes](https://github.com/reactjs/react-transition-group/releases)
- [Changelog](https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md)
- [Commits](reactjs/react-transition-group@v2.9.0...v4.4.5)

---
updated-dependencies:
- dependency-name: react-transition-group
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
still need to udpate react-smooth
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 10, 2023 13:39 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 10, 2023 13:39 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 10, 2023 13:39 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 10, 2023 13:39 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 10, 2023 13:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Size Change: +46.6 kB (0%)

Total Size: 12.3 MB

Filename Size Change
./packages/components/dist/TalendReactComponents.js 2.9 MB +42.5 kB (+1%)
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.15 kB -147 B (-4%)
./packages/components/dist/TalendReactComponents.min.js 654 kB +4.4 kB (+1%)
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.23 kB -151 B (-4%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.21 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.34 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 40.1 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 604 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 7.24 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 623 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 121 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.27 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.4 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 588 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.33 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 118 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.37 kB 0 B
./packages/components/dist/TalendReactComponents.css 370 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 195 kB 0 B
./packages/containers/dist/TalendReactContainers.css 2.93 kB 0 B
./packages/containers/dist/TalendReactContainers.js 493 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.56 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.73 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 105 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.61 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 25.9 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 329 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.16 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 10.1 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 65.1 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 269 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js 974 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.3 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.css 162 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js 209 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.33 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 38.8 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 34.5 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 36 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 28.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 33.5 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 379 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.52 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 15.3 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 95.4 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.57 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 51.1 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.08 kB 0 B
./packages/forms/dist/mode-json.js 48.3 kB 0 B
./packages/forms/dist/mode-python.js 4.58 kB 0 B
./packages/forms/dist/mode-sql.js 1.83 kB 0 B
./packages/forms/dist/snippets-json.js 131 B 0 B
./packages/forms/dist/snippets-python.js 3.84 kB 0 B
./packages/forms/dist/snippets-sql.js 972 B 0 B
./packages/forms/dist/TalendReactForms.css 36.7 kB 0 B
./packages/forms/dist/TalendReactForms.js 737 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.66 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 12.3 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 210 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.7 kB 0 B
./packages/forms/dist/theme-chrome.js 2.71 kB 0 B
./packages/http/dist/TalendHttp.js 23.1 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 3.98 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 25 kB 0 B
./packages/icons/dist/react.esm.js 531 kB 0 B
./packages/icons/dist/react.js 571 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 16.8 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 644 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 554 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 13.8 kB 0 B
./packages/jsfc/dist/index.js 86.7 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 92.2 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 20.6 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.js 24.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 962 B 0 B
./packages/stepper/dist/TalendReactStepper.min.js 4.05 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 988 B 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 10.4 kB 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.53 kB 0 B
./packages/theme/dist/bootstrap.css 149 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

@github-actions
Copy link
Contributor

4537

:octocat: Demo is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants