Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump d3 and @types/d3 to 7.4 #4081

Merged
merged 14 commits into from Jul 28, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 6, 2022

Bumps d3 and @types/d3. These dependencies needed to be updated together.
Updates d3 from 6.7.0 to 7.4.4

Release notes

Sourced from d3's releases.

v7.4.4

  • Fix incorrect behavior of d3.bisector when given an asymmetric comparator.

v7.4.3

v7.4.2

  • Fix off-by-one bin assignment due to rounding error in d3.bin.

v7.4.1

  • Significantly improve the performance of d3.bin.
  • Fix the implementation of d3.thresholdScott.
  • d3.pack and d3.packEnclose are now fully deterministic.
  • d3.pack and d3.packEnclose now handle certain floating point errors better.

v7.4.0

v7.3.0

v7.2.1

  • Fix stratify.path when the top-level directory is only a single character.
  • Fix stratify.path when paths contain multiple trailing slashes.

v7.2.0

v7.1.1

  • d3.rank can now take a comparator in addition to an accessor.
  • d3.rank, d3.sort, d3.bisector, and d3.groupSort now require comparators to have exactly two arguments.

v7.1.0

v7.0.4

  • Default the base-10 log tick format to ~s (SI) instead of .0e (exponential).

v7.0.3

... (truncated)

Commits

Updates @types/d3 from 6.7.5 to 7.4.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [d3](https://github.com/d3/d3) and [@types/d3](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/d3). These dependencies needed to be updated together.

Updates `d3` from 6.7.0 to 7.4.4
- [Release notes](https://github.com/d3/d3/releases)
- [Changelog](https://github.com/d3/d3/blob/main/CHANGES.md)
- [Commits](d3/d3@v6.7.0...v7.4.4)

Updates `@types/d3` from 6.7.5 to 7.4.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/d3)

---
updated-dependencies:
- dependency-name: d3
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: "@types/d3"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 6, 2022
@dependabot dependabot bot temporarily deployed to pull_request_unsafe June 6, 2022 15:08 Inactive
@dependabot dependabot bot temporarily deployed to pull_request_unsafe June 6, 2022 15:08 Inactive
@dependabot dependabot bot had a problem deploying to pull_request_unsafe June 6, 2022 15:08 Failure
@dependabot dependabot bot temporarily deployed to pull_request_unsafe June 6, 2022 15:08 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 6, 2022 15:32 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 6, 2022 15:32 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 6, 2022 15:32 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 6, 2022 15:32 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 6, 2022 15:32 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Size Change: +180 B (0%)

Total Size: 12.1 MB

Filename Size Change
./packages/datagrid/dist/TalendReactDatagrid.js 177 kB +115 B (0%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.35 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.4 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 39.7 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 604 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 6.94 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 623 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 121 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.27 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.5 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 537 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.33 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 106 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.37 kB 0 B
./packages/components/dist/TalendReactComponents.css 356 kB 0 B
./packages/components/dist/TalendReactComponents.js 2.83 MB +23 B (0%)
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.17 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 183 kB 0 B
./packages/components/dist/TalendReactComponents.min.js 635 kB +12 B (0%)
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.25 kB 0 B
./packages/containers/dist/TalendReactContainers.css 2.93 kB 0 B
./packages/containers/dist/TalendReactContainers.js 435 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.56 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.73 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 88.8 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.61 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.css 20.3 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 1.39 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.css 7.38 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 39.9 kB +58 B (0%)
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 1.43 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 24.2 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 320 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.16 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 8.73 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 61.3 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 154 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js 1.08 MB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.57 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.css 94.5 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js 232 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.61 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 39 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 34.5 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 36.2 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 28.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 31.9 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 363 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.53 kB -28 B (-2%)
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 14.8 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 94.2 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.6 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 49.5 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.08 kB 0 B
./packages/forms/dist/mode-json.js 48.3 kB 0 B
./packages/forms/dist/mode-python.js 4.61 kB 0 B
./packages/forms/dist/mode-sql.js 1.83 kB 0 B
./packages/forms/dist/snippets-json.js 131 B 0 B
./packages/forms/dist/snippets-python.js 3.84 kB 0 B
./packages/forms/dist/snippets-sql.js 972 B 0 B
./packages/forms/dist/TalendReactForms.css 34.8 kB 0 B
./packages/forms/dist/TalendReactForms.js 736 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.69 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 11.7 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 210 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.73 kB 0 B
./packages/forms/dist/theme-chrome.js 2.71 kB 0 B
./packages/http/dist/TalendHttp.js 23.1 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 3.98 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 24.6 kB 0 B
./packages/icons/dist/react.esm.js 531 kB 0 B
./packages/icons/dist/react.js 571 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 16.8 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 643 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 554 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 13.3 kB 0 B
./packages/jsfc/dist/index.js 86.4 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 92.2 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 20.6 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.js 24.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 962 B 0 B
./packages/stepper/dist/TalendReactStepper.min.js 4.05 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 988 B 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 9.15 kB 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.53 kB 0 B
./packages/theme/dist/bootstrap.css 149 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

4081

:octocat: Demo is available here

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 9, 2022 12:06 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 9, 2022 12:06 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 9, 2022 12:06 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 9, 2022 12:06 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 9, 2022 12:06 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 30, 2022 09:11 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 30, 2022 09:11 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 30, 2022 09:11 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 30, 2022 09:11 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 30, 2022 09:11 Inactive
@jmfrancois
Copy link
Collaborator

wait for recharts/recharts#2893

@jmfrancois jmfrancois changed the title chore(deps): bump d3 and @types/d3 chore(deps): bump d3 and @types/d3 to 7.4 Jul 20, 2022
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:55 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:55 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:55 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:55 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:55 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:57 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:57 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:57 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:57 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 07:57 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 12:12 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 12:12 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 12:12 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 12:12 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 27, 2022 12:12 Inactive
@jmfrancois
Copy link
Collaborator

I have to share with you recent investigation with d3 7.x upgrade. They have put ecmascript modules in their "main" entry in package.json. This by default break jest which has current only experimental support for this (documented [here]https://github.com/facebook/jest/blob/64de4d7361367fd711a231d25c37f3be89564264/docs/ECMAScriptModules.md)

THe main point to discuss is about the possible options for this PR:
1️⃣ activate babel transform on all node_modules (the case in the PR, make test slower but more resilient for the future)
2️⃣ only transform the current needed package in this case (d3 + d3-* + few other deps). In this case we will add more and more modules here
3️⃣ an other option is to use moduleNameMapper to use transpiled versions of d3 libs like here

Side note: this has been accelerated by the fact recharts has released the upgrade under a fix release

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 28, 2022 12:45 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 28, 2022 12:45 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 28, 2022 12:45 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 28, 2022 12:45 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 28, 2022 12:45 Inactive
@jmfrancois jmfrancois merged commit b02eb9e into master Jul 28, 2022
@jmfrancois jmfrancois deleted the dependabot/npm_and_yarn/d3-and-types/d3-7.4.4 branch July 28, 2022 13:21
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe July 28, 2022 13:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants