Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic cdn): handle @types packages and package without varName #3916

Merged
merged 1 commit into from Apr 25, 2022

Conversation

jmfrancois
Copy link
Collaborator

@jmfrancois jmfrancois commented Apr 25, 2022

What is the problem this PR is trying to solve?

Recharts depends on @types packages but theses package do not have main so we ends with :

DynamicCdnWebpackPlugin ERROR: 
❌ @types/d3-interpolate couldn't be loaded because it is not found by require.resolve

DynamicCdnWebpackPlugin ERROR: 
❌ @types/d3-scale couldn't be loaded because it is not found by require.resolve

DynamicCdnWebpackPlugin ERROR: 
❌ @types/d3-shape couldn't be loaded because it is not found by require.resolve

I have proposed a fix here recharts/recharts#2843.

Also when there is no varName in a package it can result with module added but considered as not added.
This is the case for design system in react components:

❌ @talend/design-system 2.3.0 couldn't be loaded because peer dependency is missing @talend/locales-design-system /Users/jmfrancois/github/talend/ui/packages/components/src/Icon

What is the chosen solution to this problem?

Ensure dependencies do not start with @types scope.

Ensure addModule return at least true when there is no varName

return cdnConfig.varName || true

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 25, 2022 12:52 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 25, 2022 12:52 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 25, 2022 12:52 Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 25, 2022 12:52 Inactive
@jmfrancois jmfrancois changed the title fix(dynamic cdn): handle package without varName fix(dynamic cdn): handle @types packages and package without varName Apr 25, 2022
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 14.8 MB

ℹ️ View Unchanged
Filename Size
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 41.5 kB
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 643 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 8.04 kB
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 665 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 52.6 kB
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.07 kB
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 11.5 kB
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.11 kB
./packages/cmf/dist/TalendReactCmf.js 548 kB
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.25 kB
./packages/cmf/dist/TalendReactCmf.min.js 112 kB
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.29 kB
./packages/components/dist/TalendReactComponents.css 181 kB
./packages/components/dist/TalendReactComponents.js 3.18 MB
./packages/components/dist/TalendReactComponents.js.dependencies.json 2.91 kB
./packages/components/dist/TalendReactComponents.min.js 711 kB
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 2.98 kB
./packages/containers/dist/TalendReactContainers.css 1.73 kB
./packages/containers/dist/TalendReactContainers.js 442 kB
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.41 kB
./packages/containers/dist/TalendReactContainers.min.js 95.3 kB
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.45 kB
./packages/datagrid/dist/TalendReactDatagrid.css 66 kB
./packages/datagrid/dist/TalendReactDatagrid.js 118 kB
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 1.34 kB
./packages/datagrid/dist/TalendReactDatagrid.min.js 21.9 kB
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 1.38 kB
./packages/dataviz/dist/TalendReactDataviz.css 6.94 kB
./packages/dataviz/dist/TalendReactDataviz.js 831 kB
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 854 B
./packages/dataviz/dist/TalendReactDataviz.min.js 572 kB
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 877 B
./packages/design-system/dist/TalendDesignSystem.css 1.18 MB
./packages/design-system/dist/TalendDesignSystem.js 1.17 MB
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.36 kB
./packages/design-system/dist/TalendDesignSystem.min.js 188 kB
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.39 kB
./packages/design-tokens/dist/TalendDesignTokens.css 35.2 kB
./packages/design-tokens/dist/TalendDesignTokens.js 33.3 kB
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 27.5 kB
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 15 kB
./packages/faceted-search/dist/TalendReactFacetedSearch.js 371 kB
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.29 kB
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 94.7 kB
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.32 kB
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 56.7 kB
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 935 B
./packages/forms/dist/TalendReactForms.css 20.7 kB
./packages/forms/dist/TalendReactForms.js 1.35 MB
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.82 kB
./packages/forms/dist/TalendReactForms.min.js 417 kB
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.86 kB
./packages/http/dist/TalendHttp.js 26.4 kB
./packages/http/dist/TalendHttp.js.dependencies.json 2 B
./packages/http/dist/TalendHttp.min.js 4.82 kB
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B
./packages/icons/dist/bundle.js 6.31 kB
./packages/icons/dist/info.js 10.8 kB
./packages/icons/dist/react.esm.js 530 kB
./packages/icons/dist/react.js 570 kB
./packages/icons/dist/talend-icons-webfont.css 16.7 kB
./packages/icons/dist/talendicons.css 334 B
./packages/icons/dist/TalendIcons.js 626 kB
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B
./packages/icons/dist/TalendIcons.min.js 554 kB
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B
./packages/jsfc/dist/index.js 92.6 kB
./packages/jsfc/dist/index.js.dependencies.json 2 B
./packages/router-bridge/dist/TalendRouterBridge.js 160 kB
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 981 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 24.5 kB
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.01 kB
./packages/sagas/dist/TalendReactSagas.js 12.1 kB
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B
./packages/sagas/dist/TalendReactSagas.min.js 2.13 kB
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B
./packages/stepper/dist/TalendReactStepper.js 26.3 kB
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 834 B
./packages/stepper/dist/TalendReactStepper.min.js 4.86 kB
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 856 B
./packages/theme/dist/bootstrap.css 149 kB
./packages/theme/dist/bootstrap.js 4.33 kB
./packages/theme/dist/bootstrap.js.dependencies.json 3 B

compressed-size-action

@github-actions
Copy link
Contributor

3916

:octocat: Demo is available here

@jmfrancois jmfrancois merged commit 28df3ee into master Apr 25, 2022
@jmfrancois jmfrancois deleted the jmfrancois/fix/dynamic-cdn-withoutvarname branch April 25, 2022 14:27
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe April 25, 2022 14:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants