Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update react and enzyme #2123

Merged
merged 6 commits into from Apr 1, 2019
Merged

chore: update react and enzyme #2123

merged 6 commits into from Apr 1, 2019

Conversation

jare-talend
Copy link

@jare-talend jare-talend commented Apr 1, 2019 •
edited

What is the problem this PR is trying to solve?
enzyme doesn't use the latest version (3.9.0)
use react 16.8.5 to support hook with shallow test(facebook/react#15120)

What is the chosen solution to this problem?
update yarn.lock

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jare-talend jare-talend self-assigned this Apr 1, 2019
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@jsomsanith-tlnd
Copy link
Contributor

jsomsanith-tlnd commented Apr 1, 2019 •
edited

I don't think this is the solution. You should update the versions in package.json, and it will update the yarn.lock.
Removing/recreating the yarn.lock is not really reviewable :/
And more importantly, the defined dependencies are not correct.

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

1 similar comment
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@jsomsanith-tlnd jsomsanith-tlnd changed the title chore(ui): update yarn.lock with the latest versions chore: update react and enzyme Apr 1, 2019
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

romainseb
romainseb approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@romainseb romainseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
( the description mention react version to be 16.8.5 but it's 16.8.6 in the code :) )

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@jsomsanith-tlnd jsomsanith-tlnd merged commit 2c45b74 into master Apr 1, 2019
@jsomsanith-tlnd jsomsanith-tlnd deleted the jare/fix/update-yarn-lock branch April 1, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainseb romainseb romainseb approved these changes

@jsomsanith-tlnd jsomsanith-tlnd jsomsanith-tlnd approved these changes

Assignees

@jare-talend jare-talend

Labels
enhancement need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jare-talend @build-travis-ci @jsomsanith-tlnd @romainseb