Issue #407: Migrate to arrow 1.0.0 #408
Conversation
- requirements.txt: specify arrow==1.00 - frames.py, fullmoon.py, watson.py: change "timestamp" to "int_timestamp"
- cli.py: change "date.tzinfo = tz.tzlocal()" to "date.replace(tzinfo=tz.tzlocal())"
This makes sense, especially given that arrow is already up to 1.0.2 Co-authored-by: Julien Maupetit <jmaupetit@users.noreply.github.com>
I took a quick look and there is an issue with timezone localization, making "add --from" and "add --to" work incorrectly. I need to investigate further. |
- watson.cli.py: use date = date.replace(tzinfo=tz.tzlocal()) (date.replace does not modify the existing object)
Update unit test cases: - tests/test_cli.py: replace arrow.arrow.datetime with arrow.arrow.dt_datetime - tests/test_watson.py: replace .timestamp with .int_timestamp
|
I fixed the unit test cases and also another issue with the timezone. The proper way to change the timezone of an arrow date is now: The travis build failed because arrow 1.0.0 is not available for python 3.5. |
|
Thank you so much @veganjay 🙏
Agreed! Can you add consequent changes in this PR & fill the CHANGELOG to mention arrow major release upgrade + dropped python 3.5 support? Thx ❤️ |
- .travis.yml: remove python 3.5 - setup.py: require python >= 3.6 - CHANGELOG.md: mention arrow upgrade and drop of python 3.5 support
|
Removed support for 3.5 and updated the CHANGELOG. By the way, I installed td-watson with pipx: This way the arrow library and other dependencies are installed in their own isolated environment. This is helpful if working on various other virtualenvs during the day. |
The arrow library moved to 1.0.0 on February 24, 2021 and with it came breaking changes.
This pull request addresses those changes per the arrow migration guide.