remove WatchMissingNodeModulesPlugin

due to facebook/create-react-app#11201
Taillook · Dec 15, 2021 · 497caaf · 497caaf
1 parent ac167d1
commit 497caaf
Show file tree

Hide file tree

Showing 7 changed files with 247 additions and 10 deletions.
diff --git a/lib/builder-webpack4/src/preview/iframe-webpack.config.ts b/lib/builder-webpack4/src/preview/iframe-webpack.config.ts
@@ -4,7 +4,6 @@ import { DefinePlugin, HotModuleReplacementPlugin, ProgressPlugin } from 'webpac
 import type { Configuration, RuleSetRule } from '@types/webpack';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
 import CaseSensitivePathsPlugin from 'case-sensitive-paths-webpack-plugin';
-import WatchMissingNodeModulesPlugin from 'react-dev-utils/WatchMissingNodeModulesPlugin';
 import TerserWebpackPlugin from 'terser-webpack-plugin';
 import VirtualModulePlugin from 'webpack-virtual-modules';
 import PnpWebpackPlugin from 'pnp-webpack-plugin';
@@ -19,7 +18,6 @@ import {
   es6Transpiler,
   handlebars,
   interpolate,
-  nodeModulesPaths,
   Options,
   toImportFn,
   normalizeStories,
@@ -212,7 +210,6 @@ export default async (options: Options & Record<string, any>): Promise<Configura
         ...stringifyProcessEnvs(envs),
         NODE_ENV: JSON.stringify(envs.NODE_ENV),
       }),
-      isProd ? null : new WatchMissingNodeModulesPlugin(nodeModulesPaths),
       isProd ? null : new HotModuleReplacementPlugin(),
       new CaseSensitivePathsPlugin(),
       quiet ? null : new ProgressPlugin({}),

diff --git a/lib/builder-webpack5/src/preview/iframe-webpack.config.ts b/lib/builder-webpack5/src/preview/iframe-webpack.config.ts
@@ -8,7 +8,6 @@ import {
 } from 'webpack';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
 import CaseSensitivePathsPlugin from 'case-sensitive-paths-webpack-plugin';
-import WatchMissingNodeModulesPlugin from 'react-dev-utils/WatchMissingNodeModulesPlugin';
 import TerserWebpackPlugin from 'terser-webpack-plugin';
 import VirtualModulePlugin from 'webpack-virtual-modules';
 import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin';
@@ -19,7 +18,6 @@ import {
   toRequireContextString,
   es6Transpiler,
   stringifyProcessEnvs,
-  nodeModulesPaths,
   handlebars,
   interpolate,
   Options,
@@ -217,7 +215,6 @@ export default async (options: Options & Record<string, any>): Promise<Configura
         NODE_ENV: JSON.stringify(process.env.NODE_ENV),
       }),
       new ProvidePlugin({ process: 'process/browser.js' }),
-      isProd ? null : new WatchMissingNodeModulesPlugin(nodeModulesPaths),
       isProd ? null : new HotModuleReplacementPlugin(),
       new CaseSensitivePathsPlugin(),
       quiet ? null : new ProgressPlugin({}),

diff --git a/lib/core-server/src/__snapshots__/cra-ts-essentials_manager-dev b/lib/core-server/src/__snapshots__/cra-ts-essentials_manager-dev
@@ -244,3 +244,248 @@ Object {
   ],
 }
 `;
+
+exports[`cra-ts-essentials preview dev mode 1`] = `
+Object {
+  "entry": Array [
+    "NODE_MODULES/@storybook/addon-ie11/dist/event-source-polyfill.js",
+    "ROOT/lib/core-client/dist/esm/globals/polyfills.js",
+    "ROOT/lib/core-client/dist/esm/manager/index.js",
+    "ROOT/addons/docs/dist/esm/register.js",
+    "ROOT/addons/controls/dist/esm/register.js",
+    "ROOT/addons/actions/dist/esm/register.js",
+    "ROOT/addons/backgrounds/dist/esm/register.js",
+    "ROOT/addons/toolbars/dist/esm/register.js",
+    "ROOT/addons/measure/dist/esm/register.js",
+    "ROOT/addons/outline/dist/esm/register.js",
+  ],
+  "keys": Array [
+    "name",
+    "mode",
+    "bail",
+    "devtool",
+    "entry",
+    "output",
+    "watchOptions",
+    "plugins",
+    "module",
+    "resolve",
+    "resolveLoader",
+    "recordsPath",
+    "performance",
+    "optimization",
+  ],
+  "module": Object {
+    "rules": Array [
+      Object {
+        "exclude": Array [
+          "NODE_MODULES/",
+          "/dist/",
+        ],
+        "include": Array [
+          "ROOT",
+        ],
+        "test": "/\\\\.(mjs|tsx?|jsx?)$/",
+        "use": Array [
+          Object {
+            "loader": "NODE_MODULES/babel-loader/lib/index.js",
+            "options": Object {
+              "babelrc": false,
+              "configFile": false,
+              "plugins": Array [
+                "NODE_MODULES/@babel/plugin-transform-shorthand-properties/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-block-scoping/lib/index.js",
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-decorators/lib/index.js",
+                  Object {
+                    "legacy": true,
+                  },
+                ],
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-class-properties/lib/index.js",
+                  Object {
+                    "loose": true,
+                  },
+                ],
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-private-methods/lib/index.js",
+                  Object {
+                    "loose": true,
+                  },
+                ],
+                "NODE_MODULES/@babel/plugin-proposal-export-default-from/lib/index.js",
+                "NODE_MODULES/@babel/plugin-syntax-dynamic-import/lib/index.js",
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-object-rest-spread/lib/index.js",
+                  Object {
+                    "loose": true,
+                    "useBuiltIns": true,
+                  },
+                ],
+                "NODE_MODULES/@babel/plugin-transform-classes/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-arrow-functions/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-parameters/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-destructuring/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-spread/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-for-of/lib/index.js",
+                "NODE_MODULES/babel-plugin-macros/dist/index.js",
+                "NODE_MODULES/@babel/plugin-proposal-optional-chaining/lib/index.js",
+                "NODE_MODULES/@babel/plugin-proposal-nullish-coalescing-operator/lib/index.js",
+                Array [
+                  "NODE_MODULES/babel-plugin-polyfill-corejs3/lib/index.js",
+                  Object {
+                    "absoluteImports": "NODE_MODULES/core-js/index.js",
+                    "method": "usage-global",
+                    "version": "*",
+                  },
+                ],
+                "NODE_MODULES/@babel/plugin-transform-template-literals/lib/index.js",
+              ],
+              "presets": Array [
+                Array [
+                  "NODE_MODULES/@babel/preset-env/lib/index.js",
+                  Object {
+                    "loose": true,
+                    "shippedProposals": true,
+                  },
+                ],
+                "NODE_MODULES/@babel/preset-typescript/lib/index.js",
+                "NODE_MODULES/@babel/preset-react/lib/index.js",
+              ],
+              "sourceType": "unambiguous",
+            },
+          },
+        ],
+      },
+      Object {
+        "include": [Function],
+        "test": "/\\\\.js$/",
+        "use": Array [
+          Object {
+            "loader": "NODE_MODULES/babel-loader/lib/index.js",
+            "options": Object {
+              "plugins": Array [
+                "NODE_MODULES/@babel/plugin-transform-shorthand-properties/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-block-scoping/lib/index.js",
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-decorators/lib/index.js",
+                  Object {
+                    "legacy": true,
+                  },
+                ],
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-class-properties/lib/index.js",
+                  Object {
+                    "loose": true,
+                  },
+                ],
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-private-methods/lib/index.js",
+                  Object {
+                    "loose": true,
+                  },
+                ],
+                "NODE_MODULES/@babel/plugin-proposal-export-default-from/lib/index.js",
+                "NODE_MODULES/@babel/plugin-syntax-dynamic-import/lib/index.js",
+                Array [
+                  "NODE_MODULES/@babel/plugin-proposal-object-rest-spread/lib/index.js",
+                  Object {
+                    "loose": true,
+                    "useBuiltIns": true,
+                  },
+                ],
+                "NODE_MODULES/@babel/plugin-transform-classes/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-arrow-functions/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-parameters/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-destructuring/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-spread/lib/index.js",
+                "NODE_MODULES/@babel/plugin-transform-for-of/lib/index.js",
+                "NODE_MODULES/babel-plugin-macros/dist/index.js",
+                "NODE_MODULES/@babel/plugin-proposal-optional-chaining/lib/index.js",
+                "NODE_MODULES/@babel/plugin-proposal-nullish-coalescing-operator/lib/index.js",
+                Array [
+                  "NODE_MODULES/babel-plugin-polyfill-corejs3/lib/index.js",
+                  Object {
+                    "absoluteImports": "NODE_MODULES/core-js/index.js",
+                    "method": "usage-global",
+                    "version": "*",
+                  },
+                ],
+              ],
+              "presets": Array [
+                Array [
+                  "NODE_MODULES/@babel/preset-env/lib/index.js",
+                  Object {
+                    "loose": true,
+                    "modules": false,
+                    "shippedProposals": true,
+                    "targets": "defaults",
+                  },
+                ],
+                "NODE_MODULES/@babel/preset-react/lib/index.js",
+              ],
+              "sourceType": "unambiguous",
+            },
+          },
+        ],
+      },
+      Object {
+        "test": "/\\\\.css$/",
+        "use": Array [
+          "NODE_MODULES/style-loader/dist/cjs.js",
+          Object {
+            "loader": "NODE_MODULES/css-loader/dist/cjs.js",
+            "options": Object {
+              "importLoaders": 1,
+            },
+          },
+        ],
+      },
+      Object {
+        "loader": "NODE_MODULES/file-loader/dist/cjs.js",
+        "options": Object {
+          "name": "static/media/[path][name].[ext]",
+        },
+        "test": "/\\\\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\\\\?.*)?$/",
+      },
+      Object {
+        "loader": "NODE_MODULES/url-loader/dist/cjs.js",
+        "options": Object {
+          "limit": 10000,
+          "name": "static/media/[path][name].[ext]",
+        },
+        "test": "/\\\\.(mp4|webm|wav|mp3|m4a|aac|oga)(\\\\?.*)?$/",
+      },
+      Object {
+        "include": "NODE_MODULES[\\\\\\\\/](@storybook[\\\\\\\\/]node_logger|@testing-library[\\\\\\\\/]dom|@testing-library[\\\\\\\\/]user-event|acorn-jsx|ansi-align|ansi-colors|ansi-escapes|ansi-regex|ansi-styles|better-opn|boxen|camelcase|chalk|color-convert|commander|find-cache-dir|find-up|fs-extra|highlight.js|json5|node-fetch|pkg-dir|prettier|pretty-format|react-dev-utils|resolve-from|semver|slash|strip-ansi|uuid)/",
+        "test": "/\\\\.js$/",
+        "use": Array [
+          Object {
+            "loader": "NODE_MODULES/babel-loader/lib/index.js",
+            "options": Object {
+              "presets": Array [
+                Array [
+                  "@babel/preset-env",
+                  Object {
+                    "targets": Object {
+                      "ie": "11",
+                    },
+                  },
+                  "storybook-addon-ie11",
+                ],
+              ],
+              "sourceType": "unambiguous",
+            },
+          },
+        ],
+      },
+    ],
+  },
+  "plugins": Array [
+    "VirtualModulesPlugin",
+    "HtmlWebpackPlugin",
+    "CaseSensitivePathsPlugin",
+    "DefinePlugin",
+  ],
+}
+`;
diff --git a/lib/core-server/src/__snapshots__/cra-ts-essentials_preview-dev b/lib/core-server/src/__snapshots__/cra-ts-essentials_preview-dev
@@ -473,7 +473,6 @@ Object {
     "VirtualModulesPlugin",
     "HtmlWebpackPlugin",
     "DefinePlugin",
-    "WatchMissingNodeModulesPlugin",
     "HotModuleReplacementPlugin",
     "CaseSensitivePathsPlugin",
     "ProgressPlugin",
@@ -488,3 +487,5 @@ Object {
   ],
 }
 `;
+
+exports[`cra-ts-essentials preview production mode 1`] = `null`;
diff --git a/lib/core-server/src/__snapshots__/html-kitchen-sink_preview-dev b/lib/core-server/src/__snapshots__/html-kitchen-sink_preview-dev
@@ -459,7 +459,6 @@ Object {
     "VirtualModulesPlugin",
     "HtmlWebpackPlugin",
     "DefinePlugin",
-    "WatchMissingNodeModulesPlugin",
     "HotModuleReplacementPlugin",
     "CaseSensitivePathsPlugin",
     "ProgressPlugin",

diff --git a/lib/core-server/src/__snapshots__/vue-3-cli_preview-dev b/lib/core-server/src/__snapshots__/vue-3-cli_preview-dev
@@ -497,7 +497,6 @@ Object {
     "VirtualModulesPlugin",
     "HtmlWebpackPlugin",
     "DefinePlugin",
-    "WatchMissingNodeModulesPlugin",
     "HotModuleReplacementPlugin",
     "CaseSensitivePathsPlugin",
     "ProgressPlugin",

diff --git a/lib/core-server/src/__snapshots__/web-components-kitchen-sink_preview-dev b/lib/core-server/src/__snapshots__/web-components-kitchen-sink_preview-dev
@@ -496,7 +496,6 @@ Object {
     "VirtualModulesPlugin",
     "HtmlWebpackPlugin",
     "DefinePlugin",
-    "WatchMissingNodeModulesPlugin",
     "HotModuleReplacementPlugin",
     "CaseSensitivePathsPlugin",
     "ProgressPlugin",