[FEATURE] Add support for composer.json only extensions #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this only go into the |
|
I'm fine with both. I personally need this in one project where we apply this as a patch. |
|
Looks like there is somehow an issue with loading order within acceptance tests … I'll investiage. |
DanielSiepmann
force-pushed
the
541-support-composer-only
branch
from
15af862
to
912733d
Compare
The internal array always uses the extension key.
Not having an ext_emconf.php with dependencies to extension keys, but
only a composer.json with dependencies to package names will always
result in:
UnexpectedValueException: The package "extension_key" depends on "composer/package-key" which is not present in the system.
This is a common situation in modern TYPO3 projects where multiple
extensions are given which declare their internal dependencies to have
proper TYPO3 loading order.
A fallback from the dependency (which might be the composer name) to the
actual extension key is added.
Resolves: TYPO3#541
DanielSiepmann
force-pushed
the
541-support-composer-only
branch
from
912733d
to
db0d6a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal array always uses the extension key.
Not having an ext_emconf.php with dependencies to extension keys, but only a composer.json with dependencies to package names will always result in:
This is a common situation in modern TYPO3 projects where multiple extensions are given which declare their internal dependencies to have proper TYPO3 loading order.
A fallback from the dependency (which might be the composer name) to the actual extension key is added.
Resolves: #541