Commits on Apr 6, 2023

1. [!!!][TASK] Avoid setMethods() on mocks …

   setMethods() has been removed with phpunit 10.
   
   $this->getAccessibleMock() used this to only
   partially mock a test subject. The patch switches
   to onlyMethods() now.
   
   There is one difference: onlyMethods() fails if
   a methods that should be mocked does not exist,
   while setMethods() did not fail on this.
   
   So this is more strict now. It was frequently used in
   core tests mocking ['dummy'] to say "mock no method".
   Those have to be switched to use 'null' as argument
   to $this->getAccessibleMock() now. Also, when a class
   is refactored, and a method that has been previously
   mocked is removed with the refactoring, the mock has
   to be adapted to remove the method-mock request from
   the test as well now, otherwise the test will fail.
   
   Rules for the second argument of getAccessibleMock():
   
   * "keep all methods, mock nothing": Hand over 'null'
   * "mock all methods": Hand over empty array [] (default)
   * "mock single methods": Hand over an array with method names
   
   Releases: main, 7
   Resolves: #444

   

   lolli42 committed Apr 6, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 80d28ef
   • Browse repository at this point

   Copy the full SHA

   80d28ef View commit details

   Browse the repository at this point in the history