[TASK] Address PHPStan remarks

TYPO3 · Jan 24, 2024 · de54fa4 · de54fa4
1 parent cf926c5
commit de54fa4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/src/Controller/Admin/RequirementCrudController.php b/src/Controller/Admin/RequirementCrudController.php
@@ -43,7 +43,7 @@ public static function getEntityFqcn(): string
         return Requirement::class;
     }
 
-    public function createEntity(string $entityFqcn)
+    public function createEntity(string $entityFqcn): Requirement
     {
         return Requirement::create();
     }

diff --git a/src/Entity/Requirement.php b/src/Entity/Requirement.php
@@ -99,7 +99,7 @@ public function getId(): ?int
         return $this->id;
     }
 
-    public function setVersion(MajorVersion $version): void
+    public function setVersion(?MajorVersion $version): void
     {
         $this->version = $version;
     }

diff --git a/src/EventListener/RequirementListener.php b/src/EventListener/RequirementListener.php
@@ -37,16 +37,25 @@ public function __construct(
 
     public function postUpdate(Requirement $requirement, PostUpdateEventArgs $eventArgs): void
     {
-        $this->cacheService->purgeMajorVersion((string)$requirement->getVersion()->getVersion());
+        $majorVersion = $requirement->getVersion();
+        if ($majorVersion !== null) {
+            $this->cacheService->purgeMajorVersion((string)$majorVersion->getVersion());
+        }
     }
 
     public function postRemove(Requirement $requirement, PostRemoveEventArgs $eventArgs): void
     {
-        $this->cacheService->purgeMajorVersion((string)$requirement->getVersion()->getVersion());
+        $majorVersion = $requirement->getVersion();
+        if ($majorVersion !== null) {
+            $this->cacheService->purgeMajorVersion((string)$majorVersion->getVersion());
+        }
     }
 
     public function postPersist(Requirement $requirement, PostPersistEventArgs $eventArgs): void
     {
-        $this->cacheService->purgeMajorVersion((string)$requirement->getVersion()->getVersion());
+        $majorVersion = $requirement->getVersion();
+        if ($majorVersion !== null) {
+            $this->cacheService->purgeMajorVersion((string)$majorVersion->getVersion());
+        }
     }
 }