Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelling of progress. #422

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

acinader
Copy link

@acinader acinader commented Feb 2, 2019

No description provided.

@bikeath1337
Copy link
Collaborator

Let's start with creating a correctly-spelled alias for the method and include a test that verified it. As it stands, this change can easily break existing usage.

@acinader
Copy link
Author

acinader commented Feb 3, 2019

hi @bikeath1337

I added a deprecation warning and kept the current function.

found another typo in the evaporate.spec.js file.

I haven't figured out how to test the FileUpload change yet.

I have never used ava and I can't figure out how to

a) run a single test
b) halt in a either chrome debugger or vscode debugger so I can figure out what is going on :).

@jakubzitny
Copy link
Collaborator

a) test.only
b) vscode debugger should respect the breakpoints (or debugger) as you'd expect if configured properly, adding following to configurations in launch.json should do just fine

{
  "type": "node",
  "request": "attach",
  "name": "node debug"
},

@acinader
Copy link
Author

acinader commented Feb 4, 2019

@jakubzitny well test.only works like a charm, but debugging not yet.

In your suggestion above, how do you start the debugger? If I just npm test, then the node runtime isn't in debug mode for vscode to attach to? If I try:

./node_modules/.bin/babel-node --inspect-brk node_modules/ava/profile.js test/evaporate.spec.js

I get this error in the debugger:

Error: Cannot find module './test/helpers/browser-env.js'

which is the same error I get when I try a vscode config like:

        {
            "type": "node",
            "request": "launch",
            "name": "Run AVA test",
            "program": "${workspaceFolder}/node_modules/ava/profile.js",
            "args": [
              "test/evaporate.spec.js"
            ],
            "skipFiles": [
                "<node_internals>/**/*.js"
            ],
        }

which I got from: https://github.com/avajs/ava/blob/master/docs/recipes/debugging-with-vscode.md

I understand what browser-env is trying to do, i'm just not sure how to invoke at the command line rather than using npm and have browser-env do its thing....

@jakubzitny
Copy link
Collaborator

Any plans on finishing this @acinader ?

@acinader
Copy link
Author

acinader commented Apr 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants