Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add full name restrictions/assertions to members API #205

Merged
merged 4 commits into from
Jul 29, 2019
Merged

add full name restrictions/assertions to members API #205

merged 4 commits into from
Jul 29, 2019

Commits on Jul 29, 2019

  1. remove duplicate import 

    introduced with efbbc32 after rebase

Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
    @hankem @codecholeric
    hankem authored and codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    c45ffe1 View commit details
    Browse the repository at this point in the history

  2. add members().that().{have,doNotHave}FullName[Not][Matching] syntax 

    Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
    @hankem @codecholeric
    hankem authored and codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    291d1d5 View commit details
    Browse the repository at this point in the history

  3. add members().should().{have,notHave}FullName[Not][Matching] syntax 

    Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
    @hankem @codecholeric
    hankem authored and codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    5879c48 View commit details
    Browse the repository at this point in the history

  4. Review: 

    - Added some Javadoc (since I'm not sure if 'full name' can be immediately understood by every user)
- Removed the generic return type from the predicates in HasName and HasName.AndFullName since the caller should be responsible to map to the subtype (or it would have to be consistently changed in many other places)
- Tried to make some tests more decisive by matching at least some element of the passed collection
- Unrelated: Added HasName.AndFullName.Functions.GET_FULL_NAME to be consistent with HasName

Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    @codecholeric
    codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    71a524e View commit details
    Browse the repository at this point in the history