Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add classes().that().areAnyClass(...) to syntax #173

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Add classes().that().areAnyClass(...) to syntax #173

merged 4 commits into from
Jul 29, 2019

Commits on Jul 29, 2019

  1. Add classes().that().areAnyClass(...) to syntax 

    Signed-off-by: Mobolaji Adefope <mbadefop@edu.uwaterloo.ca>
    @mobolajiadefope-toast @codecholeric
    mobolajiadefope-toast authored and codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    8c1189c View commit details
    Browse the repository at this point in the history

  2. Create tests 

    Signed-off-by: Mobolaji Adefope <mbadefop@edu.uwaterloo.ca>
    @mobolajiadefope-toast @codecholeric
    mobolajiadefope-toast authored and codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    283a56d View commit details
    Browse the repository at this point in the history

  3. Remove non-anonymous inner class matching 

    Signed-off-by: Mobolaji Adefope <mbadefop@edu.uwaterloo.ca>
    @moboa @codecholeric
    moboa authored and codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    19c5297 View commit details
    Browse the repository at this point in the history

  4. Review: I think it is a more consistent API if we just treat all inne… 

    …r classes the same, be they anonymous or named. Thus call the method "belongTo" and define "belong" as being the class or any nested inner class. We should extend that to nested levels as well, since using an anonymous class within an anonymous class should not be counted any different IMHO.

Also improved tests a little to actually test the nested case which is the more interesting one.

Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    @codecholeric
    codecholeric committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    c90991f View commit details
    Browse the repository at this point in the history