-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add classes().that().areAnyClass(...) to syntax #167
Conversation
Signed-off-by: Mobolaji Adefope <mbadefop@edu.uwaterloo.ca>
Signed-off-by: Mobolaji Adefope <mbadefop@edu.uwaterloo.ca>
Hey, thanks a lot 😃 Looks like a reasonable addition. Can you do me a favor though and sign off your commits according to the DCO? -> https://github.com/TNG/ArchUnit/blob/master/CONTRIBUTING.md#commits |
fe3bf12
to
80f49fd
Compare
DeepCode encountered a problem when analyzing this pull request. If you want to retry, create a comment: "Retry Deepcode". |
Retry Deepcode |
DeepCode analyzed this pull request. |
One thing that really gives me a stomach ache is the fact that
|
It only matches anonymous inner classes. This is mostly to catch lambdas. |
I think that for I'm trying to come up with a situation where we want to match the class but not match anonymous inner classes and not coming up with much. |
I don't doubt that in this case you probably always want to cover lambdas as well. But inner classes also covers |
Oops. Did not notice i was matching with non-anonymous inner classes. Will fix this. |
Lost push access to toasttab fork so created #173 |
Extended the API to allow assertions to made against one or multiple types using class objects.
E.g. The declaration
should pass if only
Bar
andBaz
and any of their anonymous inner classes depend onFoo
.