Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc and code updates and bug fixing #285

Merged
merged 8 commits into from Dec 20, 2021
Merged

Doc and code updates and bug fixing #285

merged 8 commits into from Dec 20, 2021

Conversation

ferpasri
Copy link
Member

@ferpasri ferpasri commented Dec 7, 2021 •
edited

Update:

  • gradle wrapper version to 7.1.1
  • remove old Windows UIAutomation windows.dll build instructions from readme (move to wiki for advanced users)
  • Use the AbstractIDCustom tag (instead ConcreteID) to identify actions and states in QLearning and StateGraph algorithms
  • Update Dockerfile java version. Openjdk-16 is the Ubuntu 20.04 LTS version Update Dockerfile openjdk-14-jdk to openjdk-16-jdk #279

Fix bugs:

@ferpasri
fix replay mode canvas issue
42af84f 
Visualize filtered actions with replay mode throws an exception because global canvas object was not used by replay loop
@ferpasri
use abstractCustomId in SimpleGuiStateGraph algorithms
dc6580e 
- Use the AbstractIDCustom tag (instead ConcreteID) to identify actions and states in QLearning and StateGraph algorithms
@ferpasri
fix IllegalStateException message
d4a789a
@ferpasri
update docker java version to 16
63bbec0 
Fix #279
openjdk-16 is the Ubuntu 20.04 LTS version
@ferpasri
update gradlew version and readme
7332050 
- Update gradle wrapper to 7.1.1
- Remove old windows UIAutomation instructions from readme, and move them to wiki as advanced instructions
@ferpasri
Copy link
Member Author

ferpasri commented Dec 9, 2021 •
edited

Waiting for upload artifact issue because replay mode creates an empty 0kb log
actions/upload-artifact#270

TODO: Update log4j version and TESTAR version

@ferpasri
fix upload-artifact and update log4j
68ef14d 
- Workaround for a github workflow issue that does not allow to upload 0 bytes artifacts
- Update log4j to 2.15.0 for vulnerability reasons
@ferpasri
Copy link
Member Author

Now the parabank server is off, let's wait for next Monday :)

pekkakaho
pekkakaho approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@pekkakaho pekkakaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes ok, seems to work ok for desktop and web, and replay works too

@ferpasri ferpasri merged commit ae6fc62 into master Dec 20, 2021
@ferpasri ferpasri deleted the master_documentation branch December 20, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekkakaho pekkakaho pekkakaho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferpasri @pekkakaho