Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor: view results: fix IndexOutOfBoundsException #8415 #8714

Merged
merged 15 commits into from
Apr 17, 2018
Merged

Instructor: view results: fix IndexOutOfBoundsException #8415 #8714

merged 15 commits into from
Apr 17, 2018

Commits on Apr 16, 2018

  1. Fix outOfBoundsException in FeedbackMsqQuestionDetails.java

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    2bd2f4a View commit details
    Browse the repository at this point in the history

  2. Added numOfMsqChoices in UI test

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    d277fb5 View commit details
    Browse the repository at this point in the history

  3. Fix style guide violation

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    6897b97 View commit details
    Browse the repository at this point in the history

  4. Refactor getQuestionAdditionalInfoHtml

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    2d5d29b View commit details
    Browse the repository at this point in the history

  5. Resolve merge conflict with master

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    73ff564 View commit details
    Browse the repository at this point in the history

  6. Replace instances of numOfMsqChoices with mcqChoices.size()

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    5c45a7c View commit details
    Browse the repository at this point in the history

  7. Make changes to consider team_excluding_self

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    38582da View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary methods to generate numOfMsqChoices

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    1c81285 View commit details
    Browse the repository at this point in the history

  9. Fix style guide violation

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    b496173 View commit details
    Browse the repository at this point in the history

  10. Remove numOfMsqChoices field in InstructorFeedbackResultsPageUiTest.j… 

    …son for generated options
    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    1940693 View commit details
    Browse the repository at this point in the history

  11. Fix style guide violation

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    5123753 View commit details
    Browse the repository at this point in the history

  12. Remove numOfMsqChoices field in FeedbackMsqQuestionDetails.java

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    7a3e055 View commit details
    Browse the repository at this point in the history

  13. Remove numOfMsqChoices in json test data

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    2061785 View commit details
    Browse the repository at this point in the history

  14. Minor fixes 

    Change method name, method visibility, and method parameter name for getNumOfChoicesForMsq in FeedbackMsqQuestionDetails.
Removed the method getNumOfMsqChoices().
Replaced getRequestParamValue with getNonNullRequestParamValue for editQuestion() method in InstructorFeedbackQuestionEditAction.
    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    341d083 View commit details
    Browse the repository at this point in the history

  15. Cosmetic changes

    @Haozhe321
    Haozhe321 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    1030ee7 View commit details
    Browse the repository at this point in the history