Util types for special Omit cases #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, and I haven't looked for this yet, there's probably libraries of util types out there already. I bet they'd cover the implementation of something like this for us. Preferable to import a package over maintaining these utils our self, they're a little tricky to read and don't have unit tests written for them here. |
Merged
…fixed an edge case bug that I'd caught in IndexTypeSafeOmit and adds symbol support, nice
…r out of date prettier version doesn't understand
…Add util_types.d.ts to .prettierignore for now, will remove that line on the prettier 2.3 branch
Stephen-ONeil
changed the title
ktw1016
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As encountered here, using the built in Omit util on a something that has any index types on it will give an unexpected result... Although they say it's the expected behaviour regardless 🤷 .
Scrounged up a handful of useful util types from the various discussions of this issue. We'll probably want to use
IndexTypeSafeOmit* pretty much anywhere we need to omit keys, since it doesn't have the fiddly gotcha of the built-in.* names in this branch feel kinda awkward, would welcome any better suggestions!