Npm 7 dependency cleanup #1084
Closed
Npm 7 dependency cleanup #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors/warnings fixed (eslint-babel had deprecated)
…or version to squash some deprecated warnings
…and sorted out some peer dependecy missmatching in the process
…oose arrays instead of plain arrays (TODO, probably don't actually want this, look in to that). Update some bad est doc keys in data/test-data/covid_estimates.test while I'm at it
…olyfill, use core-js via @babel/preset-env config. Some of the current packages (graphiql, react-virtualized) technically still require React 16 (but work with 17) so the npm 7 upgrade will be a bit awkward if we need to reinstall those before they're updated to support 17. For now, they won't complain during CI's and installs of other packages, will just make noise if you do a full re-install (dropping the existing package lock and nuking your /node_modules first)
…f changes that comes with that can be a different PR
Stephen-ONeil
force-pushed
the
npm-7-dependency-cleanup
branch
from
2b3baa3
to
0c3462e
Compare
…er-webpack-plugin 3... wouldn't have to if other dependencies didn't prevent us from using npm 7 without --legacy-peer-deps, ha
…package.json, pretty sure npm 7 peer dependency management will solve that problem in /server and /email_backend now
|
Paused to give various packages time to make npm-7 friendly releases. Probably want at least a partial fix to #1092 before this continues. May end up needing to restart this branch/make careful cherry-picks due to other package changes that have happened in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pave the way for us all to get together on the same page with npm version 7 (will need to happen before this merges). Bunch of package upgrading and a couple small config changes in the process.
TODO:
IB_base, something's broken with the latestcss-minimizer-webpack-plugin(ironically, might be a missing peer dependency, oof)/scripts/common_node_scriptsisn't installing correctly"usage"option which is nice but likely makes build memory usage worse. If CI is back to running out of memory than may need to try"entry"instead (temporarily)/serverhad a bunch ofcoreMongooseArrayobjects appearing in the snapshot output. Investigate further--legacy-peer-depsflag, maybe open an issue to revisit that in a few months when maintainers have had time to catch up)