Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of "extlinks" #1842

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Improve handling of "extlinks" #1842

merged 7 commits into from
Jun 3, 2024

Conversation

YoshiRulz
Copy link
Collaborator

No description provided.

@YoshiRulz
Copy link
Collaborator Author

@nattthebear Is this the right approach? It's working well now, but I foresee problems with trying to combine rel values—specifically, I'm thinking of adding rel="ugc" to only some wiki-format excerpts, but as I've written it that would override the other values. So I would need to pass "noopener external nofollow ugc" and then that has to be kept in sync. Is there an existing mechanism for combining class that I've overlooked?

@nattthebear
Copy link
Collaborator

@YoshiRulz I don't think you're missing any capabilities. The system has about enough abstraction layers to handle what it does, but no more.

@YoshiRulz
Copy link
Collaborator Author

Then should I contribute first-class support for those attributes before finalising this?

@nattthebear
Copy link
Collaborator

If you think it's useful, I could see some sort of rel and class handling as a useful part of the Node capabilities.

@adelikat
Copy link
Collaborator

adelikat commented Jun 2, 2024

@YoshiRulz : can you fix the merge conflicts in this PR? and then I'll merge

@adelikat adelikat merged commit 3b16091 into TASVideos:main Jun 3, 2024
1 check passed
@YoshiRulz YoshiRulz deleted the extlink branch June 3, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants