Prevent select element from flashing right before it's replaced #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only way to accommodate noscript users
YoshiRulz
reviewed
Feb 28, 2024
| @@ -27,6 +27,7 @@ | |||
| <link rel="alternate" href="/publications.rss" type="application/rss+xml" title="TASVideos RSS Publication Feed"> | |||
| <link rel="alternate" href="/wiki.rss" type="application/rss+xml" title="TASVideos RSS Wiki Feed"> | |||
| <partial name="_MetaTags" /> | |||
| <script>document.head.appendChild(document.createElement("style")).innerHTML = '.d-none-js { display: none !important; }';</script> | |||
There was a problem hiding this comment.
Alternatively:
Suggested change
| <script>document.head.appendChild(document.createElement("style")).innerHTML = '.d-none-js { display: none !important; }';</script> | |
| <!-- can move to main stylesheet --><style>:root.supports-js .d-none-js { display: none !important; }</style> | |
| <script>document.documentElement.classList.add("supports-js");</script> |
There was a problem hiding this comment.
(I can't test right now) Have you tested whether that prevents the flashing on repeated reloading on the usual browsers on desktop and mobile?
It may look the same, but I noticed adding a <style> blocks cached rendering better than adding a css class.
There was a problem hiding this comment.
I haven't (I also can't test atm)
|
I'm not sure i want this PR |
|
I'm converting this to a draft, I want to try out the suggested thing and some other stuff. If I can't find anything, I'll just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at this code, this feels very hacky.