Exercise 4 wip #8
Conversation
Detail: - change apollo-datasource-rest with apollo-datasource - rewrite class Post - update votePost - update schema - add context - update server.js: add JWT, middleware, g-shield - exercise-4.md Completed: For an implemented signup feature. ⭐ For a software-tested signup feature. ⭐ For password validation. ⭐ For unique email address validation. ⭐ For not having security issues according to instructions.
- Removing this.context in PostDatasource - Adding currUser in Context
- Test >> returns a JWT - Remove this.votes, add new funtion getVotes() for Post class - Using Map for this.voters - Using initialize in datasources - Edit resolver, datasources - Adding 2 permissions isEmailTaken and isPasswordShort
using the extend standard
ich habe den Gruppennamen hinzugefügt
- Move the "list" variable from App.vue to ListNews.vue - Delete props "list" in ListNews.vue
…tle when creating - Use computed properties for the list of ordered items - Change the name of the "vote" property to "votes" - Validate title when creating (for empty or null)
Co-authored-by: Robert Schäfer <git@roschaefer.de>
FIX: Applying commit suggestions Co-authored-by: Robert Schäfer <git@roschaefer.de>
backend: - fix downvotePost () webapp: - News : adding mutation upvote(), downvote() - ListNews : get postlist, repair the function addNews, fix temporary duplicate id error when creating. - CreateNews: add new variable currentUser, return id of new post when using emit. Note: Some bugs occur when deleting and creating
- Add nodemon, crypto - Add Test files - Fix bug duplicate ID when creating - Add classes User and Post - Edit server.js, post- and users-data-source.js Co-Authored-By: Andrej <11981882+aloparev@users.noreply.github.com>
- Removing this.context in PostDatasource - Adding currUser in Context
- Test >> returns a JWT - Remove this.votes, add new funtion getVotes() for Post class - Using Map for this.voters - Using initialize in datasources - Edit resolver, datasources - Adding 2 permissions isEmailTaken and isPasswordShort
using the extend standard
|
Wow! I see that you did major refactorments, bugfixes and improvements compared to branch exercise-4. ⭐ For an implemented signup feature. 10/10 ⭐ Though I have to say it took me a while to see that you created not just another branch, but also a second PR (we save direct links to your PRs whenever you open one for an exercise). Hope you got well into 2021! |
Homework exercise 4, final version with rebase and our review of another team.