Fix BC break in PHPUnit 8 #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Feb 2, 2019
| @@ -13,7 +13,9 @@ abstract class AbstractConfigurationConstraint extends Constraint | |||
|
|
|||
| public function __construct(ConfigurationInterface $configuration, $breadcrumbPath = null) | |||
| { | |||
| parent::__construct(); | |||
| if (property_exists($this, 'exporter')) { | |||
There was a problem hiding this comment.
Is this really a safe way to check what version it is?
Could we improve?
There was a problem hiding this comment.
I suppose we can use PHPUnit\Runner\Version class to check for the version. Let me know and I'll update on Monday.
There was a problem hiding this comment.
What about what I did in #60 ?
|
Yeah. I think that is more safe
//Tobias Nyholm
… On 2 Feb 2019, at 20:38, Edi Modrić ***@***.***> wrote:
@emodric commented on this pull request.
In PhpUnit/AbstractConfigurationConstraint.php:
> @@ -13,7 +13,9 @@ abstract class AbstractConfigurationConstraint extends Constraint
public function __construct(ConfigurationInterface $configuration, $breadcrumbPath = null)
{
- parent::__construct();
+ if (property_exists($this, 'exporter')) {
I suppose we can use PHPUnit\Runner\Version class to check for the version. Let me know and I'll update on Monday.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Closed in favor of #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraint::$exporterproperty was made private andConstraint::__constructremoved in PHPUnit 8: sebastianbergmann/phpunit#3060