ci: remove redundant 'cd build'; use 'set -e' in scripts #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the removal of
|
mithro
reviewed
Dec 15, 2021
| - name: Deploy website | ||
| if: github.event_name == 'push' | ||
| run: | | ||
| git config --global user.name SymbiFlow | ||
| git config --global user.mail robot@mith.ro | ||
| git config --global push.default simple | ||
| git fetch origin --tags |
There was a problem hiding this comment.
We want --tags so that git describe gives the right output.
There was a problem hiding this comment.
Option fetch-depth: 0 was implemented for this use case. See:
https://github.com/actions/checkout/#usage
# Number of commits to fetch. 0 indicates all history for all branches and tags.
# Default: 1
fetch-depth: ''
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
|
Closing because of https://github.com/f4pga/f4pga-website/tree/main/.github/workflows.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a couple of minor enhancements to the CI scripts.