add dependency injection conflict #13715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
Feb 28, 2022
SirDomin
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
SirDomin
force-pushed
the
fix-build-sylius
branch
from
802ba0f
to
01a627f
Compare
SirDomin
changed the title
Zales0123
approved these changes
Feb 28, 2022
|
Thanks, @SirDomin! 🎉 |
mbabker
reviewed
Mar 7, 2022
|
|
||
| These versions are causing a problem with mink session: | ||
| `InvalidArgumentException: Specify session name to get in vendor/friends-of-behat/mink/src/Mink.php:198`, | ||
| Psalm error: |
There was a problem hiding this comment.
This one really should be dealt with in the Sylius Psalm config, the test environment bug is a big thing to conflict against but this one really needs an application-level fix. See symfony/symfony#45627 and vimeo/psalm#7703 for more context.
lchrusciel
added a commit
that referenced
this pull request
Mar 7, 2022
…more (Zales0123) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Definitely still not a proper solution (#13715 was not one either), but a hot-fix for making the build 🟢 again 🖖 Commits ------- ac527ae [Fix Build] Conflict with symfony/dependency-injection even more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.