-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain | Exclude tests, specs & behat from zip archives #12607
Conversation
Hello, Thanks for that 鉂わ笍 |
So I guess that reducing size by almost half is quite good result 馃槃 |
0a15fbb
to
a1a39a5
Compare
Yes, this is a good result 馃挭馃徏 |
/phpstan.neon.dist export-ignore | ||
/phpunit.xml.dist export-ignore | ||
/psalm.xml export-ignore | ||
/src/Sylius/Behat export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃毃 We need to include Behat contexts and pages, lots of plugins depend on them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just run composer install with --prefer-source
.
Perhaps a note somewhere will help.
@@ -0,0 +1,14 @@ | |||
/adr export-ignore | |||
/docs export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤 This one would be a quick win!
@@ -0,0 +1,9 @@ | |||
/Behat export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this directory exists only in ApiBundle.
@@ -0,0 +1,9 @@ | |||
/Behat export-ignore | |||
/fixtures export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this one, but I'm not sure if any bundle has this directory.
Please read for Symfony decision why this is good idea: symfony/symfony#33579
This also improves our 馃實 impact as developers cause smaller zips, mean less traffic, which reduces can a little reduce amount of pollution 馃彮 !
master