Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain | Exclude tests, specs & behat from zip archives #12607

Closed
wants to merge 1 commit into from

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented May 6, 2021

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no*
Deprecations? no
License MIT

Please read for Symfony decision why this is good idea: symfony/symfony#33579

This also improves our 馃實 impact as developers cause smaller zips, mean less traffic, which reduces can a little reduce amount of pollution 馃彮 !

Current master My PR
Zip ~32M Zip ~18M

@stloyd stloyd requested a review from a team as a code owner May 6, 2021 16:15
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Shop ShopBundle related issues and PRs. labels May 6, 2021
@oallain
Copy link
Member

oallain commented May 6, 2021

Hello,

Thanks for that 鉂わ笍
Have you been able to do a benchmark to see the benefit of this change?

@stloyd
Copy link
Contributor Author

stloyd commented May 7, 2021

@oallain

Current master My PR
Zip ~32M Zip ~18M

So I guess that reducing size by almost half is quite good result 馃槃

@oallain
Copy link
Member

oallain commented May 7, 2021

@oallain

Current master My PR
Zip ~32M Zip ~18M
So I guess that reducing size by almost half is quite good result

Yes, this is a good result 馃挭馃徏

/phpstan.neon.dist export-ignore
/phpunit.xml.dist export-ignore
/psalm.xml export-ignore
/src/Sylius/Behat export-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃毃 We need to include Behat contexts and pages, lots of plugins depend on them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just run composer install with --prefer-source.
Perhaps a note somewhere will help.

@@ -0,0 +1,14 @@
/adr export-ignore
/docs export-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 This one would be a quick win!

@@ -0,0 +1,9 @@
/Behat export-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this directory exists only in ApiBundle.

@@ -0,0 +1,9 @@
/Behat export-ignore
/fixtures export-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one, but I'm not sure if any bundle has this directory.

@stloyd stloyd closed this Mar 6, 2023
@stloyd stloyd deleted the feature/gitattributes branch March 6, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants